Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 839673004: Test that custom element callback fires before DOMContentLoaded event. (Closed)

Created:
5 years, 11 months ago by kouhei (in TOK)
Modified:
5 years, 11 months ago
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Test that custom element callback fires before DOMContentLoaded event. This CL ensures that the bug 425790 is fixed. The implementation was fixed on r187949. BUG=425790 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
A LayoutTests/fast/dom/custom/callback-timing.html View 1 chunk +23 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/custom/callback-timing-expected.txt View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kouhei (in TOK)
PTAL
5 years, 11 months ago (2015-01-09 04:56:25 UTC) #2
dominicc (has gone to gerrit)
lgtm
5 years, 11 months ago (2015-01-09 07:53:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839673004/1
5 years, 11 months ago (2015-01-09 07:54:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=188129
5 years, 11 months ago (2015-01-09 09:05:02 UTC) #6
adamk
lgtm Thanks for the test!
5 years, 11 months ago (2015-01-09 17:13:09 UTC) #7
haraken
5 years, 11 months ago (2015-01-10 01:22:47 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698