Source/bindings/scripts/v8_types.py - Issue 839633003: IDL: [NoImplHeader] should not add '#include "None"'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 839633003: IDL: [NoImplHeader] should not add '#include "None"' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index 8f03281de857e011983d4ca8b23338d6daf9e9aa..eedd1e46ffcc382849130ed6c99b35a512de166c 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -439,7 +439,8 @@ def impl_includes_for_type(idl_type, interfaces_info):

includes_for_type.add('wtf/text/WTFString.h')

if base_idl_type in interfaces_info:

interface_info = interfaces_info[idl_type.base_type]

- includes_for_type.add(interface_info['include_path'])

+ if interface_info['include_path']:

+ includes_for_type.add(interface_info['include_path'])

if base_idl_type in INCLUDES_FOR_TYPE:

includes_for_type.update(INCLUDES_FOR_TYPE[base_idl_type])

if idl_type.is_typed_array:

« no previous file with comments | « Source/bindings/scripts/code_generator_v8.py ('k') | Source/bindings/tests/idls/core/TestInterface3.idl » ('j') | no next file with comments »