Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: Source/bindings/scripts/code_generator_v8.py

Issue 839633003: IDL: [NoImplHeader] should not add '#include "None"' (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.py
diff --git a/Source/bindings/scripts/code_generator_v8.py b/Source/bindings/scripts/code_generator_v8.py
index 3b153b5805ccb666149cb75a1060c1e5d248fef0..e9d6e0b5c5a128a2d9c201ebf9736b0cc2e585d5 100644
--- a/Source/bindings/scripts/code_generator_v8.py
+++ b/Source/bindings/scripts/code_generator_v8.py
@@ -191,7 +191,7 @@ class CodeGeneratorV8(CodeGeneratorBase):
# Add the include for interface itself
if IdlType(interface_name).is_typed_array:
template_context['header_includes'].add('core/dom/DOMTypedArray.h')
- else:
+ elif interface_info['include_path']:
template_context['header_includes'].add(interface_info['include_path'])
header_text, cpp_text = render_template(
include_paths, header_template, cpp_template, template_context,
@@ -212,7 +212,8 @@ class CodeGeneratorV8(CodeGeneratorBase):
interface_info = interfaces_info[dictionary_name]
include_paths = interface_info.get('dependencies_include_paths')
# Add the include for interface itself
- template_context['header_includes'].add(interface_info['include_path'])
+ if interface_info['include_path']:
+ template_context['header_includes'].add(interface_info['include_path'])
header_text, cpp_text = render_template(
include_paths, header_template, cpp_template, template_context)
header_path, cpp_path = self.output_paths(dictionary_name)
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698