Chromium Code Reviews
DescriptionIDL: [NoImplHeader] should not add '#include "None"'
[NoImplHeader] extended attribute is added for Blink-in-JS
so that developers can add DOM features without having C++
implementation. However, the current IDL compiler adds
'#include "None"' when an interface has[NoImplHeader], which
causes build errors. Fix this by not adding
interface_info['include_path'] when it is None.
Note that we can't implement DOM features in pure-JS yet;
we need .h/.cpp implementation to make privates script workable.
BUG=341031
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188179
Patch Set 1 #
Total comments: 2
Patch Set 2 : #
Messages
Total messages: 13 (5 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||