Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 839633003: IDL: [NoImplHeader] should not add '#include "None"' (Closed)

Created:
5 years, 11 months ago by bashi
Modified:
5 years, 11 months ago
Reviewers:
haraken, Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: [NoImplHeader] should not add '#include "None"' [NoImplHeader] extended attribute is added for Blink-in-JS so that developers can add DOM features without having C++ implementation. However, the current IDL compiler adds '#include "None"' when an interface has[NoImplHeader], which causes build errors. Fix this by not adding interface_info['include_path'] when it is None. Note that we can't implement DOM features in pure-JS yet; we need .h/.cpp implementation to make privates script workable. BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188179

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M Source/bindings/scripts/code_generator_v8.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/core/TestInterface3.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface3.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
bashi
PTAL?
5 years, 11 months ago (2015-01-09 08:20:23 UTC) #2
Jens Widell
LGTM https://codereview.chromium.org/839633003/diff/1/Source/bindings/scripts/code_generator_v8.py File Source/bindings/scripts/code_generator_v8.py (right): https://codereview.chromium.org/839633003/diff/1/Source/bindings/scripts/code_generator_v8.py#newcode194 Source/bindings/scripts/code_generator_v8.py:194: else: Use "elif"?
5 years, 11 months ago (2015-01-09 09:09:17 UTC) #4
bashi
Thank you for review! https://codereview.chromium.org/839633003/diff/1/Source/bindings/scripts/code_generator_v8.py File Source/bindings/scripts/code_generator_v8.py (right): https://codereview.chromium.org/839633003/diff/1/Source/bindings/scripts/code_generator_v8.py#newcode194 Source/bindings/scripts/code_generator_v8.py:194: else: On 2015/01/09 09:09:17, Jens ...
5 years, 11 months ago (2015-01-09 09:13:21 UTC) #5
haraken
LGTM
5 years, 11 months ago (2015-01-09 09:34:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839633003/20001
5 years, 11 months ago (2015-01-09 10:03:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/45489)
5 years, 11 months ago (2015-01-09 12:00:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839633003/20001
5 years, 11 months ago (2015-01-10 00:39:03 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 02:16:34 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188179

Powered by Google App Engine
This is Rietveld 408576698