Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 839583006: Allow use of checkstyle outside of main PRESUBMIT.py (Closed)

Created:
5 years, 11 months ago by davileen
Modified:
5 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow use of checkstyle outside of main PRESUBMIT.py This commit allows the use of checkstyle outside of the main PRESUBMIT script in src. Since checkstyle can possibly be called from a subfolder of src the absolute path to the java files are used instead of relative to src. We also honor the EXCLUDED_PATH blacklist for Java files. BUG=446633 Committed: https://crrev.com/72d7653361ab398205c46239ecbc5cd25a85900f Cr-Commit-Position: refs/heads/master@{#312287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/android/checkstyle/checkstyle.py View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
davileen
Hi brettw, This is a suggested fix for https://code.google.com/p/chromium/issues/detail?id=446633 Let me know what you think. ...
5 years, 11 months ago (2015-01-06 22:57:06 UTC) #2
davileen
On 2015/01/06 22:57:06, davileen wrote: > Hi brettw, > > This is a suggested fix ...
5 years, 11 months ago (2015-01-14 23:44:45 UTC) #3
brettw
lgtm
5 years, 11 months ago (2015-01-20 20:40:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/839583006/1
5 years, 11 months ago (2015-01-20 21:13:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 22:30:37 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 22:33:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72d7653361ab398205c46239ecbc5cd25a85900f
Cr-Commit-Position: refs/heads/master@{#312287}

Powered by Google App Engine
This is Rietveld 408576698