PRESUBMIT.py - Issue 839583006: Allow use of checkstyle outside of main PRESUBMIT.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 839583006: Allow use of checkstyle outside of main PRESUBMIT.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index d41cc7574a008a546551c86da513dd07463917bd..15a160234a41d1dc1277b37226fc8d4d00891fa3 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -1264,7 +1264,8 @@ def _CheckJavaStyle(input_api, output_api):

sys.path = original_sys_path

return checkstyle.RunCheckstyle(

- input_api, output_api, 'tools/android/checkstyle/chromium-style-5.0.xml')

+ input_api, output_api, 'tools/android/checkstyle/chromium-style-5.0.xml',

+ black_list=_EXCLUDED_PATHS)

def _CheckForCopyrightedCode(input_api, output_api):

« no previous file with comments | « no previous file | tools/android/checkstyle/checkstyle.py » ('j') | no next file with comments »