Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 839573002: On Mac: Hide any popup menus on the active view before switching to another. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 41a767e7da3fe91aac8fa5579ed60d5240b79bb7..79ec93d21d314ef9a045106a1e263f418539f33d 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1073,6 +1073,12 @@ void WebContentsImpl::WasHidden() {
FOR_EACH_OBSERVER(WebContentsObserver, observers_, WasHidden());
+#if defined(OS_MACOSX)
+ RenderViewHostDelegateView* view = GetDelegateView();
+ if (view)
+ view->HidePopupMenu();
+#endif
Avi (use Gerrit) 2015/01/06 15:46:39 Android also uses external popup menus; do we want
+
should_normally_be_visible_ = false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698