On Mac: Hide any popup menus on the active view before switching to another.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 1055 matching lines @@
       if (*iter)
         (*iter)->Hide();
     }
 
     // Release any video power save blockers held as video is not visible.
     video_power_save_blocker_.reset();
   }
 
   FOR_EACH_OBSERVER(WebContentsObserver, observers_, WasHidden());
 
+#if defined(OS_MACOSX)
+  RenderViewHostDelegateView* view = GetDelegateView();
+  if (view)
+    view->HidePopupMenu();
+#endif

[Avi (use Gerrit), 2015/01/06 15:46:39]

Android also uses external popup menus; do we want to do this for them?

Also, I'm very suspicious of this code being in this file.
ShowPopupMenu/HidePopupMenu calls are made in RenderFrameHostImpl. Why should
this code go here?

+
   should_normally_be_visible_ = false;
 }
 
 bool WebContentsImpl::NeedToFireBeforeUnload() {
   // TODO(creis): Should we fire even for interstitial pages?
   return WillNotifyDisconnection() &&
       !ShowingInterstitialPage() &&
       !static_cast<RenderViewHostImpl*>(
           GetRenderViewHost())->SuddenTerminationAllowed();
 }
@@ skipping 3295 matching lines @@
   node->render_manager()->ResumeResponseDeferredAtStart();
 }
 
 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
   force_disable_overscroll_content_ = force_disable;
   if (view_)
     view_->SetOverscrollControllerEnabled(CanOverscrollContent());
 }
 
 }  // namespace content