Issue 8395026: Merge 107203 - [Sync UI] Disable the "Advanced..." button when there is an unrecoverable sync error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8395026: Merge 107203 - [Sync UI] Disable the "Advanced..." button when there is an unrecoverable sync error. (Closed)

Created:
9 years, 1 month ago by binji

Modified:
9 years, 1 month ago

Reviewers:
binji

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/branches/912/src/

Visibility:
Public.

Merge 107203 - [Sync UI] Disable the "Advanced..." button when there is an unrecoverable sync error. BUG=94976 TEST=Trigger an unrecoverable error. Go to chrome://settings/personal. The advanced button should be disabled. If the error is cleared, the button should be available again. Review URL: http://codereview.chromium.org/8332019 TBR=binji@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107244

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	chrome/browser/resources/options/personal_options.js	View		2 chunks	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/webui/options/personal_options_handler.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)