[Sync UI] Disable the "Advanced..." button when there is an unrecoverable sync error.

[Sync UI] Disable the "Advanced..." button when there is an unrecoverable sync error.

BUG=94976
TEST=Trigger an unrecoverable error. Go to chrome://settings/personal. The advanced button should be disabled. If the error is cleared, the button should be available again.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107203

[James Hawkins, 2011-10-25 17:50:41]

http://codereview.chromium.org/8332019/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/personal_options_handler.cc (right):

http://codereview.chromium.org/8332019/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/personal_options_handler.cc:253: bool
has_unrecoverable_error = service->unrecoverable_error_detected();
No need for temp var.

[binji, 2011-10-25 18:14:33]

http://codereview.chromium.org/8332019/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/personal_options_handler.cc (right):

http://codereview.chromium.org/8332019/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/personal_options_handler.cc:253: bool
has_unrecoverable_error = service->unrecoverable_error_detected();
On 2011/10/25 17:50:41, James Hawkins wrote:
> No need for temp var.

Done.

[James Hawkins, 2011-10-25 18:22:32]

lgtm

[commit-bot: I haz the power, 2011-10-25 19:59:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/8332019/1002

[commit-bot: I haz the power, 2011-10-25 21:15:26]

Change committed as 107203