Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 839473005: Simplify ScopedStyleResolver keyframe handling. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
rafaelw, ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Simplify ScopedStyleResolver keyframe handling. Just linearly search for keyframes in the set of stylesheets. Components rarely have many sheets, and sheets rarely have many keyframes so this should be quite fast. It's also much simpler than having to collect all the keyframes from all the rulesets. R=ojan@chromium.org, rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6aa376f26803cf3d50055fd6362a7eb0b7dad5f5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -40 lines) Patch
M sky/engine/core/animation/css/CSSAnimations.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/css/CSSAnimations.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.h View 2 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +8 lines, -23 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -4 lines 1 comment Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
https://codereview.chromium.org/839473005/diff/1/sky/engine/core/css/resolver/StyleResolver.h File sky/engine/core/css/resolver/StyleResolver.h (left): https://codereview.chromium.org/839473005/diff/1/sky/engine/core/css/resolver/StyleResolver.h#oldcode201 sky/engine/core/css/resolver/StyleResolver.h:201: KeyframesRuleMap m_keyframesRuleMap; This code was just dead.
5 years, 11 months ago (2015-01-07 07:23:50 UTC) #1
ojan
lgtm
5 years, 11 months ago (2015-01-07 18:43:55 UTC) #3
esprehn
5 years, 11 months ago (2015-01-07 18:47:49 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6aa376f26803cf3d50055fd6362a7eb0b7dad5f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698