sky/engine/core/animation/css/CSSAnimations.h - Issue 839473005: Simplify ScopedStyleResolver keyframe handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/animation/css/CSSAnimations.h

Issue 839473005: Simplify ScopedStyleResolver keyframe handling. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/animation/css/CSSAnimations.h

diff --git a/sky/engine/core/animation/css/CSSAnimations.h b/sky/engine/core/animation/css/CSSAnimations.h

index 914bd9c604dbc7785dc73b2cedc5f5073beb5396..b54f4e834ef0835c8dcdd0881c4c02798e7099ce 100644

--- a/sky/engine/core/animation/css/CSSAnimations.h

+++ b/sky/engine/core/animation/css/CSSAnimations.h

@@ -154,7 +154,7 @@ public:

// FIXME: This method is only used here and in the legacy animations

// implementation. It should be made private or file-scope when the legacy

// engine is removed.

- static const StyleRuleKeyframes* matchScopedKeyframesRule(StyleResolver*, const Element*, const StringImpl*);

+ static const StyleRuleKeyframes* matchScopedKeyframesRule(StyleResolver*, const Element*, String animationName);

static const StylePropertyShorthand& animatableProperties();

static bool isAllowedAnimation(CSSPropertyID);