Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 839463003: Remove redundant set of ResolvableLibrary.libraryElement. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index fe2a33523eb4f7a17642e1e452bcb98191f47a6f..77daa8d6e6db6fd947bf439d692c6331c9f61a79 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -7293,13 +7293,13 @@ class LibraryElementBuilder {
}
/**
- * Build the library element for the given library.
+ * Build the library element for the given library. The resulting element is
+ * stored in the [ResolvableLibrary] structure.
*
* @param library the library for which an element model is to be built
- * @return the library element that was built
* @throws AnalysisException if the analysis could not be performed
*/
- LibraryElementImpl buildLibrary2(ResolvableLibrary library) {
+ void buildLibrary2(ResolvableLibrary library) {
CompilationUnitBuilder builder = new CompilationUnitBuilder();
Source librarySource = library.librarySource;
CompilationUnit definingCompilationUnit = library.definingCompilationUnit;
@@ -7401,7 +7401,6 @@ class LibraryElementBuilder {
if (sourcedUnitCount > 0) {
_patchTopLevelAccessors(libraryElement);
}
- return libraryElement;
}
/**
@@ -8888,8 +8887,7 @@ class LibraryResolver2 {
for (ResolvableLibrary library in _librariesInCycle) {
LibraryElementBuilder builder =
new LibraryElementBuilder(analysisContext, errorListener);
- LibraryElementImpl libraryElement = builder.buildLibrary2(library);
- library.libraryElement = libraryElement;
+ builder.buildLibrary2(library);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698