Remove redundant set of ResolvableLibrary.libraryElement.

pkg/analyzer/lib/src/generated/resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.resolver;
 
 import "dart:math" as math;
 import 'dart:collection';
 
 import 'package:analyzer/src/generated/utilities_collection.dart';
@@ skipping 7275 matching lines @@
       directive.element = libraryElement;
     }
     library.libraryElement = libraryElement;
     if (sourcedUnitCount > 0) {
       _patchTopLevelAccessors(libraryElement);
     }
     return libraryElement;
   }
 
   /**
-   * Build the library element for the given library.
+   * Build the library element for the given library.  The resulting element is
+   * stored in the [ResolvableLibrary] structure.
    *
    * @param library the library for which an element model is to be built
-   * @return the library element that was built
    * @throws AnalysisException if the analysis could not be performed
    */
-  LibraryElementImpl buildLibrary2(ResolvableLibrary library) {
+  void buildLibrary2(ResolvableLibrary library) {
     CompilationUnitBuilder builder = new CompilationUnitBuilder();
     Source librarySource = library.librarySource;
     CompilationUnit definingCompilationUnit = library.definingCompilationUnit;
     CompilationUnitElementImpl definingCompilationUnitElement =
         builder.buildCompilationUnit(librarySource, definingCompilationUnit);
     NodeList<Directive> directives = definingCompilationUnit.directives;
     LibraryIdentifier libraryNameNode = null;
     bool hasPartDirective = false;
     FunctionElement entryPoint =
         _findEntryPoint(definingCompilationUnitElement);
@@ skipping 81 matching lines @@
     }
     int sourcedUnitCount = sourcedCompilationUnits.length;
     libraryElement.parts = sourcedCompilationUnits;
     for (Directive directive in directivesToResolve) {
       directive.element = libraryElement;
     }
     library.libraryElement = libraryElement;
     if (sourcedUnitCount > 0) {
       _patchTopLevelAccessors(libraryElement);
     }
-    return libraryElement;
   }
 
   /**
    * Add all of the non-synthetic getters and setters defined in the given compilation unit that
    * have no corresponding accessor to one of the given collections.
    *
    * @param getters the map to which getters are to be added
    * @param setters the list to which setters are to be added
    * @param unit the compilation unit defining the accessors that are potentially being added
    */
@@ skipping 1466 matching lines @@
 
   /**
    * Build element models for all of the libraries in the current cycle.
    *
    * @throws AnalysisException if any of the element models cannot be built
    */
   void _buildElementModels() {
     for (ResolvableLibrary library in _librariesInCycle) {
       LibraryElementBuilder builder =
           new LibraryElementBuilder(analysisContext, errorListener);
-      LibraryElementImpl libraryElement = builder.buildLibrary2(library);
-      library.libraryElement = libraryElement;
+      builder.buildLibrary2(library);
     }
   }
 
   /**
    * Build the members in enum declarations. This cannot be done while building the rest of the
    * element model because it depends on being able to access core types, which cannot happen until
    * the rest of the element model has been built (when resolving the core library).
    *
    * @throws AnalysisException if any of the enum members could not be built
    */
@@ skipping 6604 matching lines @@
    * library.
    */
   final HashSet<String> members = new HashSet<String>();
 
   /**
    * Names of resolved or unresolved class members that are read in the
    * library.
    */
   final HashSet<String> readMembers = new HashSet<String>();
 }