Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 839323002: XFA: merge patch from CL 839163002 to only request C++ 11 for C++ (Closed)

Created:
5 years, 11 months ago by brucedawson
Modified:
5 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: merge patch from CL 839163002 to only request C++ 11 for C++ Only request C++11 when compiling C++ code. Linux pdfium builds have 215 warnings of this form: command line option -std=gnu++11 is valid for C++/ObjC++ but not for C The obvious fix is to not request C++11 for C compilations. The only complication was the the switch we are using is actually gnu++0x, not gnu++11. BUG=https://code.google.com/p/pdfium/issues/detail?id=102 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/839163002 Committed: https://pdfium.googlesource.com/pdfium/+/0c753c3f98d089c184ca4fd6c11169e5796a1c48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brucedawson
Committed patchset #1 (id:1) manually as 0c753c3f98d089c184ca4fd6c11169e5796a1c48 (presubmit successful).
5 years, 11 months ago (2015-01-09 19:54:54 UTC) #1
Tom Sepez
5 years, 11 months ago (2015-01-09 20:05:52 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698