Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 839163002: Only request C++11 when compiling C++ code. (Closed)

Created:
5 years, 11 months ago by brucedawson
Modified:
5 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only request C++11 when compiling C++ code. Linux pdfium builds have 215 warnings of this form: command line option -std=gnu++11 is valid for C++/ObjC++ but not for C The obvious fix is to not request C++11 for C compilations. The only complication was the the switch we are using is actually gnu++0x, not gnu++11. BUG=https://code.google.com/p/pdfium/issues/detail?id=102 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c4457a8f623bb4f09542d98bdde9c33ca932c4a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
brucedawson
5 years, 11 months ago (2015-01-09 01:01:38 UTC) #2
Tom Sepez
Bless you sir. LGTM.
5 years, 11 months ago (2015-01-09 18:51:00 UTC) #3
brucedawson
5 years, 11 months ago (2015-01-09 19:51:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4457a8f623bb4f09542d98bdde9c33ca932c4a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698