Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 839083003: Add initial support for color output in the build system (Closed)

Created:
5 years, 11 months ago by Sam Clegg
Modified:
5 years, 11 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -30 lines) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/naclports/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/naclports/__main__.py View 1 2 5 chunks +15 lines, -5 lines 0 comments Download
M lib/naclports/binary_package.py View 1 chunk +1 line, -1 line 0 comments Download
M lib/naclports/package.py View 2 chunks +7 lines, -1 line 0 comments Download
M lib/naclports/source_package.py View 1 2 3 9 chunks +14 lines, -19 lines 0 comments Download
M lib/naclports/util.py View 1 2 5 chunks +30 lines, -1 line 0 comments Download
M requirements.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Sam Clegg
5 years, 11 months ago (2015-01-08 17:17:07 UTC) #2
binji
lgtm https://codereview.chromium.org/839083003/diff/20001/lib/naclports/binary_package.py File lib/naclports/binary_package.py (right): https://codereview.chromium.org/839083003/diff/20001/lib/naclports/binary_package.py#newcode141 lib/naclports/binary_package.py:141: self.LogStatus('Installing') this is going to do a lot ...
5 years, 11 months ago (2015-01-09 18:24:59 UTC) #3
Sam Clegg
https://codereview.chromium.org/839083003/diff/20001/lib/naclports/binary_package.py File lib/naclports/binary_package.py (right): https://codereview.chromium.org/839083003/diff/20001/lib/naclports/binary_package.py#newcode141 lib/naclports/binary_package.py:141: self.LogStatus('Installing') On 2015/01/09 18:24:59, binji wrote: > this is ...
5 years, 11 months ago (2015-01-09 22:14:54 UTC) #4
Sam Clegg
5 years, 11 months ago (2015-01-10 09:47:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
c147dd300a0fc408efba97132921c6582f656b50 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698