Add initial support for color output in the build system

Add initial support for color output in the build system

R=binji@chromium.org

Committed: https://chromium.googlesource.com/external/naclports/+/c147dd300a0fc408efba97132921c6582f656b50

[Sam Clegg, 2015-01-08 17:17:07]

sbc@chromium.org changed reviewers:
+ binji@chromium.org

[binji, 2015-01-09 18:24:59]

lgtm

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/binary_pac...
File lib/naclports/binary_package.py (right):

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/binary_pac...
lib/naclports/binary_package.py:141: self.LogStatus('Installing')
this is going to do a lot more banners in non-color mode. What does it look
like? Probably OK either way.

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/source_pac...
File lib/naclports/source_package.py (right):

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/source_pac...
lib/naclports/source_package.py:39: util.CheckForColorSupport()
hmm... maybe CheckForColorSupport should be renamed so it is clear that it is
checking sys.stdout. Otherwise this call doesn't make as much sense.

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/util.py
File lib/naclports/util.py (right):

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/util.py#ne...
lib/naclports/util.py:40: Color.enabled = sys.stdout.isatty()
Is there a better check here? Not all ttys support color, right?

[Sam Clegg, 2015-01-09 22:14:54]

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/binary_pac...
File lib/naclports/binary_package.py (right):

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/binary_pac...
lib/naclports/binary_package.py:141: self.LogStatus('Installing')
On 2015/01/09 18:24:59, binji wrote:
> this is going to do a lot more banners in non-color mode. What does it look
> like? Probably OK either way.

Done.

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/source_pac...
File lib/naclports/source_package.py (right):

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/source_pac...
lib/naclports/source_package.py:39: util.CheckForColorSupport()
On 2015/01/09 18:24:59, binji wrote:
> hmm... maybe CheckForColorSupport should be renamed so it is clear that it is
> checking sys.stdout. Otherwise this call doesn't make as much sense.

Done.

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/util.py
File lib/naclports/util.py (right):

https://codereview.chromium.org/839083003/diff/20001/lib/naclports/util.py#ne...
lib/naclports/util.py:40: Color.enabled = sys.stdout.isatty()
On 2015/01/09 18:24:59, binji wrote:
> Is there a better check here? Not all ttys support color, right?

This is the same change that "ls --color=auto" does.

This is from the stackoverflow discussion that seems to back this up:
http://unix.stackexchange.com/questions/9957/how-to-check-if-bash-can-print-c...
"Terminals that don't support ANSI color-changing sequences are rare enough that
it's acceptable to make their users override the default choice. In any case,
make sure your application has an option to force colors on or off."

So, I think as long as I add an option for force it to be disabled we should be
fine.

[Sam Clegg, 2015-01-10 09:47:01]

Committed patchset #4 (id:60001) manually as
c147dd300a0fc408efba97132921c6582f656b50 (tree was closed).