PRESUBMIT.py - Issue 839083003: Add initial support for color output in the build system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 839083003: Add initial support for color output in the build system (Closed) Base URL: https://chromium.googlesource.com/external/naclports.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 8e9dc623f1d36d0f7e52e3474f9e1c0ddd2fe8fa..a94ccf8b0ec6f9990ea209b0223808360d1003e3 100755

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -39,11 +39,11 @@ def CheckBuildbot(input_api, output_api):

def CheckDeps(input_api, output_api):

+ cmd = ['build_tools/python_wrapper', 'build_tools/check_deps.py']

try:

- subprocess.check_call(['build_tools/check_deps.py'])

+ subprocess.check_call(cmd)

except subprocess.CalledProcessError:

- message = 'update_mirror.py --check failed.'

- message += '\nRun build_tools/update_mirror.py to update.'

+ message = 'check_deps.py failed.'

return [output_api.PresubmitError(message)]

return []

« no previous file with comments | « no previous file | lib/naclports/__init__.py » ('j') | no next file with comments »