Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 839013003: CustomElementProxy annotation (Closed)

Created:
5 years, 11 months ago by jakemac
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-components.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove print #

Patch Set 3 : format #

Patch Set 4 : add some simple js interop into the test #

Total comments: 4

Patch Set 5 : code review #

Patch Set 6 : update to use initialize 0.1.1 which can rewrite script tags #

Patch Set 7 : update initialize dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -5 lines) Patch
M CHANGELOG.md View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
A lib/custom_element_proxy.dart View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
M lib/interop.dart View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M lib/interop_support.js View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 2 3 4 5 6 2 chunks +7 lines, -1 line 0 comments Download
A test/custom_element_proxy_test.dart View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
A test/custom_element_proxy_test.html View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jakemac
let me know if you think this should live in a different package (custom_element_apigen?)
5 years, 11 months ago (2015-01-20 22:32:44 UTC) #2
Siggi Cherem (dart-lang)
lgtm! As for where it goes, I was initially wondering the same thing. I think ...
5 years, 11 months ago (2015-01-20 22:48:20 UTC) #3
jakemac
https://codereview.chromium.org/839013003/diff/60001/lib/custom_element_proxy.dart File lib/custom_element_proxy.dart (right): https://codereview.chromium.org/839013003/diff/60001/lib/custom_element_proxy.dart#newcode8 lib/custom_element_proxy.dart:8: /// This will not work unless `interop_support.js` is loaded. ...
5 years, 11 months ago (2015-01-21 18:04:30 UTC) #4
jakemac
5 years, 11 months ago (2015-01-23 22:10:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
2fc77ddf4088706e10efb25599da6d44408099e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698