Replicate sandbox flags for OOPIF (Blink part 2)

Source/web/FrameLoaderClientImpl.cpp

Index: Source/web/FrameLoaderClientImpl.cpp
diff --git a/Source/web/FrameLoaderClientImpl.cpp b/Source/web/FrameLoaderClientImpl.cpp
index 7b4a5236e2964744cfb99e8f8b8a90f54f2b50d4..d4db5203e8cfbb053765e5c595e563c3c23b4f05 100644
--- a/Source/web/FrameLoaderClientImpl.cpp
+++ b/Source/web/FrameLoaderClientImpl.cpp
@@ -674,9 +674,10 @@ PassRefPtrWillBeRawPtr<LocalFrame> FrameLoaderClientImpl::createFrame(
     const KURL& url,
     const AtomicString& name,
     HTMLFrameOwnerElement* ownerElement,
-    ContentSecurityPolicyDisposition shouldCheckContentSecurityPolicy)
+    ContentSecurityPolicyDisposition shouldCheckContentSecurityPolicy,
+    SandboxFlags sandboxFlags)
 {
-    FrameLoadRequest frameRequest(m_webFrame->frame()->document(), url, name, shouldCheckContentSecurityPolicy);
+    FrameLoadRequest frameRequest(m_webFrame->frame()->document(), url, name, shouldCheckContentSecurityPolicy, sandboxFlags);

[alexmos, 2015/01/16 18:31:40]

Instead of plumbing sandboxFlags through createFrame and
FrameLoadRequest, a simpler approach is to make sandboxFlags() public in
HTMLFrameOwnerElement and access it here as ownerElement->sandboxFlags().  Is
there any reason not to make sandboxFlags() (and the rest of FrameOwner methods)
public in HTMLFrameOwnerElement?

[dcheng, 2015/01/16 19:11:19]

I haven't really thought about this. +japhet

[Nate Chapin, 2015/01/21 18:27:30]

I have mixed feelings about making all of the FrameOwner api public on
HTMLFrameOwnerElement, but I think this is a reasonable case for exposing at
least sandboxFlags().

Unless there's a situation in which we would remove sandboxFlags() from
FrameOwner and/or HTMLFrameOwnerElement, which seems unlikely?

     return m_webFrame->createChildFrame(frameRequest, ownerElement);
 }