Replicate sandbox flags for OOPIF (Blink part 2)

Source/web/FrameLoaderClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 656 matching lines @@
 // will occur.
 void FrameLoaderClientImpl::transitionToCommittedForNewPage()
 {
     m_webFrame->createFrameView();
 }
 
 PassRefPtrWillBeRawPtr<LocalFrame> FrameLoaderClientImpl::createFrame(
     const KURL& url,
     const AtomicString& name,
     HTMLFrameOwnerElement* ownerElement,
-    ContentSecurityPolicyDisposition shouldCheckContentSecurityPolicy)
+    ContentSecurityPolicyDisposition shouldCheckContentSecurityPolicy,
+    SandboxFlags sandboxFlags)
 {
-    FrameLoadRequest frameRequest(m_webFrame->frame()->document(), url, name, shouldCheckContentSecurityPolicy);
+    FrameLoadRequest frameRequest(m_webFrame->frame()->document(), url, name, shouldCheckContentSecurityPolicy, sandboxFlags);

[alexmos, 2015/01/16 18:31:40]

Instead of plumbing sandboxFlags through createFrame and
FrameLoadRequest, a simpler approach is to make sandboxFlags() public in
HTMLFrameOwnerElement and access it here as ownerElement->sandboxFlags().  Is
there any reason not to make sandboxFlags() (and the rest of FrameOwner methods)
public in HTMLFrameOwnerElement?

[dcheng, 2015/01/16 19:11:19]

I haven't really thought about this. +japhet

[Nate Chapin, 2015/01/21 18:27:30]

I have mixed feelings about making all of the FrameOwner api public on
HTMLFrameOwnerElement, but I think this is a reasonable case for exposing at
least sandboxFlags().

Unless there's a situation in which we would remove sandboxFlags() from
FrameOwner and/or HTMLFrameOwnerElement, which seems unlikely?

     return m_webFrame->createChildFrame(frameRequest, ownerElement);
 }
 
 bool FrameLoaderClientImpl::canCreatePluginWithoutRenderer(const String& mimeType) const
 {
     if (!m_webFrame->client())
         return false;
 
     return m_webFrame->client()->canCreatePluginWithoutRenderer(mimeType);
 }
@@ skipping 233 matching lines @@
 
 unsigned FrameLoaderClientImpl::backForwardLength()
 {
     WebViewImpl* webview = m_webFrame->viewImpl();
     if (!webview || !webview->client())
         return 0;
     return webview->client()->historyBackListCount() + 1 + webview->client()->historyForwardListCount();
 }
 
 } // namespace blink