public/web/WebRemoteFrame.h - Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebRemoteFrame.h

Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@iframe-sandbox-flags-part1

Patch Set: Address Daniel's comments. Move sandbox flags inheritance to FrameLoader::effectiveSandboxFlags(). Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebRemoteFrame.h

diff --git a/public/web/WebRemoteFrame.h b/public/web/WebRemoteFrame.h

index c81164e326ce7b282907e10562ecb31bbe2f9b2f..03ba5399f9786b2c8becfd1e1821284a49dbd293 100644

--- a/public/web/WebRemoteFrame.h

+++ b/public/web/WebRemoteFrame.h

@@ -17,8 +17,6 @@ class WebRemoteFrame : public WebFrame {

public:

BLINK_EXPORT static WebRemoteFrame* create(WebRemoteFrameClient*);

- // FIXME(alexmos): This will go away once the Chromium side is updated to pass sandbox flags.

- virtual WebLocalFrame* createLocalChild(const WebString& name, WebFrameClient*) = 0;

virtual WebLocalFrame* createLocalChild(const WebString& name, WebSandboxFlags, WebFrameClient*) = 0;

virtual WebRemoteFrame* createRemoteChild(const WebString& name, WebRemoteFrameClient*) = 0;

« Source/core/loader/FrameLoader.cpp ('K') | « public/web/WebFrameClient.h ('k') | no next file » | no next file with comments »