public/web/WebFrameClient.h - Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebFrameClient.h

Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@iframe-sandbox-flags-part1

Patch Set: Address Daniel's comments. Move sandbox flags inheritance to FrameLoader::effectiveSandboxFlags(). Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebFrameClient.h

diff --git a/public/web/WebFrameClient.h b/public/web/WebFrameClient.h

index 62641d2a76f6e397b5b148989bc3f621fb8c0ce5..0a0b36734e9a7ac87d1f4318cbe2863d2e743d40 100644

--- a/public/web/WebFrameClient.h

+++ b/public/web/WebFrameClient.h

@@ -41,6 +41,7 @@

#include "WebIconURL.h"

#include "WebNavigationPolicy.h"

#include "WebNavigationType.h"

+#include "WebSandboxFlags.h"

#include "WebSecurityOrigin.h"

#include "WebTextDirection.h"

#include "public/platform/WebCommon.h"

@@ -149,7 +150,7 @@ public:

// until frameDetached() is called on it.

// Note: If you override this, you should almost certainly be overriding

// frameDetached().

- virtual WebFrame* createChildFrame(WebLocalFrame* parent, const WebString& frameName) { return 0; }

+ virtual WebFrame* createChildFrame(WebLocalFrame* parent, const WebString& frameName, WebSandboxFlags sandboxFlags) { return nullptr; }

// This frame set its opener to null, disowning it.

// See http://html.spec.whatwg.org/#dom-opener.

« Source/core/loader/FrameLoader.cpp ('K') | « Source/web/tests/WebViewTest.cpp ('k') | public/web/WebRemoteFrame.h » ('j') | no next file with comments »