Source/web/tests/FrameTestHelpers.h - Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/FrameTestHelpers.h

Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@iframe-sandbox-flags-part1

Patch Set: Address Daniel's comments. Move sandbox flags inheritance to FrameLoader::effectiveSandboxFlags(). Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/FrameTestHelpers.h

diff --git a/Source/web/tests/FrameTestHelpers.h b/Source/web/tests/FrameTestHelpers.h

index 11aca4a91249a27f956d4a3c8a9a7fcc03b27763..9bbc6ecc0ca08dea6dc12436e2d4eeeea8e944e3 100644

--- a/Source/web/tests/FrameTestHelpers.h

+++ b/Source/web/tests/FrameTestHelpers.h

@@ -100,7 +100,7 @@ class TestWebFrameClient : public WebFrameClient {

public:

TestWebFrameClient();

- virtual WebFrame* createChildFrame(WebLocalFrame* parent, const WebString& frameName) override;

+ virtual WebFrame* createChildFrame(WebLocalFrame* parent, const WebString& frameName, WebSandboxFlags) override;

virtual void frameDetached(WebFrame*) override;

virtual void didStartLoading(bool) override;

virtual void didStopLoading() override;

« Source/core/loader/FrameLoader.cpp ('K') | « Source/web/WebRemoteFrameImpl.cpp ('k') | Source/web/tests/FrameTestHelpers.cpp » ('j') | no next file with comments »