Source/web/tests/FrameTestHelpers.cpp - Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/FrameTestHelpers.cpp

Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@iframe-sandbox-flags-part1

Patch Set: Address Daniel's comments. Move sandbox flags inheritance to FrameLoader::effectiveSandboxFlags(). Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/FrameTestHelpers.cpp

diff --git a/Source/web/tests/FrameTestHelpers.cpp b/Source/web/tests/FrameTestHelpers.cpp

index b765d34f58b1523b48097c0d0d01c0efb7ed02e4..219838114b118139256150dbafc0a99228c67c8e 100644

--- a/Source/web/tests/FrameTestHelpers.cpp

+++ b/Source/web/tests/FrameTestHelpers.cpp

@@ -305,7 +305,7 @@ TestWebFrameClient::TestWebFrameClient() : m_loadsInProgress(0)

{

}

-WebFrame* TestWebFrameClient::createChildFrame(WebLocalFrame* parent, const WebString& frameName)

+WebFrame* TestWebFrameClient::createChildFrame(WebLocalFrame* parent, const WebString& frameName, WebSandboxFlags sandboxFlags)

{

WebFrame* frame = WebLocalFrame::create(this);

parent->appendChild(frame);

« Source/core/loader/FrameLoader.cpp ('K') | « Source/web/tests/FrameTestHelpers.h ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »