Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: Source/core/html/HTMLFrameOwnerElement.h

Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@iframe-sandbox-flags-part1
Patch Set: Address Daniel's comments. Move sandbox flags inheritance to FrameLoader::effectiveSandboxFlags(). Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/HTMLFrameOwnerElement.cpp » ('j') | Source/core/loader/FrameLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFrameOwnerElement.h
diff --git a/Source/core/html/HTMLFrameOwnerElement.h b/Source/core/html/HTMLFrameOwnerElement.h
index b30e04fbc37703316ad581209d7bd88411178b47..090a605fac0fbca83d948fddd105f393146166e8 100644
--- a/Source/core/html/HTMLFrameOwnerElement.h
+++ b/Source/core/html/HTMLFrameOwnerElement.h
@@ -77,6 +77,11 @@ public:
void performDeferredWidgetTreeOperations();
};
+ // FrameOwner overrides:
+ virtual bool isLocal() const { return true; }
+ virtual void dispatchLoad() override;
+ virtual SandboxFlags sandboxFlags() const override { return m_sandboxFlags; }
+
virtual void trace(Visitor*) override;
protected:
@@ -89,11 +94,6 @@ private:
virtual bool isKeyboardFocusable() const override;
virtual bool isFrameOwnerElement() const override final { return true; }
- // FrameOwner overrides:
- virtual bool isLocal() const { return true; }
- virtual SandboxFlags sandboxFlags() const override;
- virtual void dispatchLoad() override;
-
RawPtrWillBeMember<Frame> m_contentFrame;
RefPtrWillBeMember<Widget> m_widget;
SandboxFlags m_sandboxFlags;
« no previous file with comments | « no previous file | Source/core/html/HTMLFrameOwnerElement.cpp » ('j') | Source/core/loader/FrameLoader.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698