Source/core/html/HTMLFrameOwnerElement.cpp - Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFrameOwnerElement.cpp

Issue 838903002: Replicate sandbox flags for OOPIF (Blink part 2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@iframe-sandbox-flags-part1

Patch Set: Address Daniel's comments. Move sandbox flags inheritance to FrameLoader::effectiveSandboxFlags(). Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFrameOwnerElement.cpp

diff --git a/Source/core/html/HTMLFrameOwnerElement.cpp b/Source/core/html/HTMLFrameOwnerElement.cpp

index b79cd40503526fbd7d2cf9b197af874d957287d5..60afa70dc23fd17e583531b24d0e0df14ac7f9e5 100644

--- a/Source/core/html/HTMLFrameOwnerElement.cpp

+++ b/Source/core/html/HTMLFrameOwnerElement.cpp

@@ -186,11 +186,6 @@ void HTMLFrameOwnerElement::setSandboxFlags(SandboxFlags flags)

m_sandboxFlags = flags;

}

-SandboxFlags HTMLFrameOwnerElement::sandboxFlags() const

- return m_sandboxFlags | document().sandboxFlags();

bool HTMLFrameOwnerElement::isKeyboardFocusable() const

{

return m_contentFrame && HTMLElement::isKeyboardFocusable();

« no previous file with comments | « Source/core/html/HTMLFrameOwnerElement.h ('k') | Source/core/loader/FrameLoader.cpp » ('j') | Source/core/loader/FrameLoader.cpp » ('J')