Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1892)

Issue 838783002: [turbofan] Cleanup Graph and related classes. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Cleanup Graph and related classes. - Move NodeMarker to its own file, and introduce a non templatized base class. - Cleanup the include hell. - Sanitize the Node construction methods now that we got rid of that GenericNode/GenericGraph stuff. - Protect against NodeId overflow in Graph. - Various minor cleanups. TEST=cctest,mjsunit,unittests Committed: https://crrev.com/e53845d41cc82f681e04c9ff2c1894f42939a292 Cr-Commit-Position: refs/heads/master@{#25977}

Patch Set 1 #

Patch Set 2 : Parameter pack causes compile errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -112 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/common-operator-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/control-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/graph.h View 1 4 chunks +22 lines, -56 lines 0 comments Download
M src/compiler/graph.cc View 2 chunks +29 lines, -19 lines 0 comments Download
M src/compiler/graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/graph-reducer.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/loop-analysis.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/node.h View 6 chunks +9 lines, -19 lines 0 comments Download
M src/compiler/node.cc View 2 chunks +8 lines, -10 lines 0 comments Download
A src/compiler/node-marker.h View 1 chunk +62 lines, -0 lines 0 comments Download
A src/compiler/node-marker.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M src/compiler/scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-graph-reducer.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-node-cache.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M test/unittests/compiler/common-operator-reducer-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/value-numbering-reducer-unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-07 13:21:36 UTC) #2
dcarney
lgtm
5 years, 11 months ago (2015-01-07 13:26:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838783002/20001
5 years, 11 months ago (2015-01-07 13:27:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 14:42:44 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 14:42:56 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e53845d41cc82f681e04c9ff2c1894f42939a292
Cr-Commit-Position: refs/heads/master@{#25977}

Powered by Google App Engine
This is Rietveld 408576698