Testcases for nameddests and navigate for PDF

chrome/browser/resources/pdf/pdf_extension_test.cc

Index: chrome/browser/resources/pdf/pdf_extension_test.cc
diff --git a/chrome/browser/resources/pdf/pdf_extension_test.cc b/chrome/browser/resources/pdf/pdf_extension_test.cc
index 64b73fada0d2172f70cea11e3956d5416a41ff54..fbbf4dbc590dc3a485a3f0dee07c340d18245a88 100644
--- a/chrome/browser/resources/pdf/pdf_extension_test.cc
+++ b/chrome/browser/resources/pdf/pdf_extension_test.cc
@@ -40,7 +40,7 @@ class PDFExtensionTest : public ExtensionApiTest {
     ExtensionApiTest::TearDownOnMainThread();
   }
 
-  void RunTestsInFile(std::string filename) {
+  void RunTestsInFile(std::string filename, std::string pdf_filename) {
     base::FilePath pdf_path;
     ASSERT_TRUE(PathService::Get(chrome::FILE_PDF_PLUGIN, &pdf_path));
     ASSERT_TRUE(
@@ -60,7 +60,7 @@ class PDFExtensionTest : public ExtensionApiTest {
 
     extensions::ResultCatcher catcher;
 
-    GURL url(embedded_test_server()->GetURL("/pdf/test.pdf"));
+    GURL url(embedded_test_server()->GetURL("/pdf/" + pdf_filename));
     GURL extension_url(
         "chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?" +
         url.spec());
@@ -85,13 +85,17 @@ class PDFExtensionTest : public ExtensionApiTest {
 };
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Basic) {
-  RunTestsInFile("basic_test.js");
+  RunTestsInFile("basic_test.js", "test.pdf");
 }
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, BasicPlugin) {
-  RunTestsInFile("basic_plugin_test.js");
+  RunTestsInFile("basic_plugin_test.js", "test.pdf");
 }
 
 IN_PROC_BROWSER_TEST_F(PDFExtensionTest, Viewport) {
-  RunTestsInFile("viewport_test.js");
+  RunTestsInFile("viewport_test.js", "test.pdf");
+}
+
+IN_PROC_BROWSER_TEST_F(PDFExtensionTest, NamedDestionations) {
+  RunTestsInFile("nameddestinations_test.js", "test_nameddestinations.pdf");

[raymes, 2015/01/23 00:01:44]

Since we're not actually using the PDF involved, we can just pass in "test.pdf"

[Deepak, 2015/01/23 14:05:15]

Done.

 }