Testcases for nameddests and navigate for PDF

chrome/test/data/pdf/nameddestinations_test.js

Index: chrome/test/data/pdf/nameddestinations_test.js
diff --git a/chrome/test/data/pdf/nameddestinations_test.js b/chrome/test/data/pdf/nameddestinations_test.js
new file mode 100644
index 0000000000000000000000000000000000000000..a61957e656ea3c2756f70d876c4bfcaa4cecd119
--- /dev/null
+++ b/chrome/test/data/pdf/nameddestinations_test.js
@@ -0,0 +1,78 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var tests = [
+  /**
+   * Test named destinations for test_nameddestinations.pdf.
+   */
+  function testNamedDestinations() {

[raymes, 2015/01/23 00:01:44]

I see you've mostly tested the params parser here, but we should do it using the
public API. We can create a new OpenPDFParamsParser just for the test and then
run a bunch of URLs through it to test it, rather than accessing the one inside
viewer.paramsParser_. Does that make sense?

[Deepak, 2015/01/23 14:05:15]

Yes, It make sense. I understood.

+    var originalUrl = viewer.streamDetails_.originalUrl;
+    // Checking #nameddest.
+    var urlParams = viewer.paramsParser_.getViewportFromUrlParams(originalUrl +
+                                                                  "#RU");
+    var page = viewer.paramsParser_.namedDestinations['RU'];
+    chrome.test.assertEq(page, urlParams.page);
+
+    // Checking #nameddest=name.
+    urlParams = viewer.paramsParser_.getViewportFromUrlParams(originalUrl +
+                                                              "#nameddest=US");
+    page = viewer.paramsParser_.namedDestinations['US'];
+    chrome.test.assertEq(urlParams.page, page);
+
+    // Checking #page=pagenum nameddest.The document’s first page has a pagenum
+    // value of 1.
+    urlParams = viewer.paramsParser_.getViewportFromUrlParams(originalUrl +
+                                                                  "#page=6");
+    chrome.test.assertEq(urlParams.page, 5);
+
+    // Checking #zoom=scale.
+    urlParams = viewer.paramsParser_.getViewportFromUrlParams(originalUrl +
+                                                                  "#zoom=200");
+    chrome.test.assertEq(urlParams.zoom, 2);
+
+    // Checking #zoom=scale,left,top.
+    urlParams = viewer.paramsParser_.getViewportFromUrlParams(originalUrl +
+                                                          "#zoom=200,100,200");
+    chrome.test.assertEq(urlParams.zoom, 2);
+    chrome.test.assertEq(urlParams.position.x, 100);
+    chrome.test.assertEq(urlParams.position.y, 200);
+
+    // Checking #nameddest=name and zoom=scale.
+    urlParams = viewer.paramsParser_.getViewportFromUrlParams(originalUrl +
+                                                  "#nameddest=UY&zoom=150");
+    page = viewer.paramsParser_.namedDestinations['UY'];
+    chrome.test.assertEq(urlParams.page, page);
+    chrome.test.assertEq(1.5, urlParams.zoom);
+
+    // Checking #page=pagenum and zoom=scale.
+    urlParams = viewer.paramsParser_.getViewportFromUrlParams(originalUrl +
+                                                          "#page=2&zoom=250");
+    chrome.test.assertEq(urlParams.page, 1);
+    chrome.test.assertEq(2.5, urlParams.zoom);
+
+    // Checking #nameddest=name and zoom=scale,left,top.
+    urlParams = viewer.paramsParser_.getViewportFromUrlParams(originalUrl +
+                                          "#nameddest=UY&zoom=150,100,200");
+    page = viewer.paramsParser_.namedDestinations['UY'];
+    chrome.test.assertEq(urlParams.page, page);
+    chrome.test.assertEq(1.5, urlParams.zoom);
+    chrome.test.assertEq(urlParams.position.x, 100);
+    chrome.test.assertEq(urlParams.position.y, 200);
+
+    // Checking #page=pagenum and zoom=scale,left,top.
+    urlParams = viewer.paramsParser_.getViewportFromUrlParams(originalUrl +
+                                                  "#page=2&zoom=250,100,200");
+    chrome.test.assertEq(urlParams.page, 1);
+    chrome.test.assertEq(2.5, urlParams.zoom);
+    chrome.test.assertEq(urlParams.position.x, 100);
+    chrome.test.assertEq(urlParams.position.y, 200);
+
+    chrome.test.succeed();
+  }
+];

[raymes, 2015/01/23 00:01:44]

Can we also add a test for the Navigator class? We can create a new Navigator
object in the test and pass in a new paramsParser and a mock viewport. We can
also pass in a mock  window object to the Navigator. Then we can call navigate()
with a bunch of different URLs and then check that the mock viewport object gets
navigated to the right places /or/ the mock window gets navigated to the right
places. To see what I mean by a "mock" class, you can look inside
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/p...

[Deepak, 2015/01/23 14:05:15]

yes,I understand your direction. I have checked it.
Thanks , This will make my understanding better about test case.
If you allow, Can I do this in a separate CL ?

+
+var scriptingAPI = new PDFScriptingAPI(window, window);
+scriptingAPI.setLoadCallback(function() {
+  chrome.test.runTests(tests);
+});