chrome/browser/password_manager/password_store_x.h - Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_x.h

Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac namespace fixes. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_store_mac.cc ('K') | « chrome/browser/password_manager/password_store_win_unittest.cc ('k') | chrome/browser/password_manager/password_store_x.cc » ('j') | components/password_manager/core/browser/login_database.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_x.h

diff --git a/chrome/browser/password_manager/password_store_x.h b/chrome/browser/password_manager/password_store_x.h

index c28ad049ac620efd9ca926a559a5adaac4d9c53d..c5c1f466547440a4d68fcc3023471a5943cffb94 100644

--- a/chrome/browser/password_manager/password_store_x.h

+++ b/chrome/browser/password_manager/password_store_x.h

@@ -69,7 +69,7 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {

// case this PasswordStoreX will act the same as PasswordStoreDefault.

PasswordStoreX(scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner,

scoped_refptr<base::SingleThreadTaskRunner> db_thread_runner,

- password_manager::LoginDatabase* login_db,

+ const base::FilePath& login_db_file_path,

NativeBackend* backend);

private: