chrome/browser/password_manager/password_store_x.cc - Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_x.cc

Issue 838453003: Open the LoginDatabase on the DB thread, not the UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac namespace fixes. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_store_mac.cc ('K') | « chrome/browser/password_manager/password_store_x.h ('k') | chrome/browser/password_manager/password_store_x_unittest.cc » ('j') | components/password_manager/core/browser/login_database.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_x.cc

diff --git a/chrome/browser/password_manager/password_store_x.cc b/chrome/browser/password_manager/password_store_x.cc

index b5eb1489ab8d0f8eb7cbb5d5995c9f2c1e06411f..8455d115b5a903d0c1db037046021e75c0b9cbab 100644

--- a/chrome/browser/password_manager/password_store_x.cc

+++ b/chrome/browser/password_manager/password_store_x.cc

@@ -41,12 +41,15 @@ bool AddLoginToBackend(const scoped_ptr<PasswordStoreX::NativeBackend>& backend,

PasswordStoreX::PasswordStoreX(

scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner,

scoped_refptr<base::SingleThreadTaskRunner> db_thread_runner,

- password_manager::LoginDatabase* login_db,

+ const base::FilePath& login_db_file_path,

NativeBackend* backend)

- : PasswordStoreDefault(main_thread_runner, db_thread_runner, login_db),

+ : PasswordStoreDefault(main_thread_runner,

+ db_thread_runner,

+ login_db_file_path),

backend_(backend),

migration_checked_(!backend),

- allow_fallback_(false) {}

+ allow_fallback_(false) {

PasswordStoreX::~PasswordStoreX() {}