Add ASAN support for Mac

Add ASAN and TSAN support for Mac

BUG=none
LOG=n
R=machenbach@chromium.org,glider@chromium.org

Committed: https://crrev.com/8216f1bc7c6b4edaa4f2f9de1efa0fc6d1fe887c
Cr-Commit-Position: refs/heads/master@{#26013}

[Michael Achenbach, 2015-01-09 12:42:48]

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi
File build/standalone.gypi (left):

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi#oldcod...
build/standalone.gypi:214: ],
Why remove this? It's still in common.gypi:
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi#newcod...
build/standalone.gypi:241: 'OTHER_CFLAGS+': [
Why +?
Why -fno-omit-frame-pointer ?

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi#newcod...
build/standalone.gypi:275: '<(DEPTH)/build/mac/asan.gyp:asan_dynamic_runtime',
I don't find the same for tsan in commmon.gypi

[jochen (gone - plz use gerrit), 2015-01-09 12:46:43]

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi
File build/standalone.gypi (left):

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi#oldcod...
build/standalone.gypi:214: ],
On 2015/01/09 at 12:42:48, Michael Achenbach wrote:
> Why remove this? It's still in common.gypi:
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...

uh, that's a mistake

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi#newcod...
build/standalone.gypi:241: 'OTHER_CFLAGS+': [
On 2015/01/09 at 12:42:48, Michael Achenbach wrote:
> Why +?
so it gets added to the list?

> Why -fno-omit-frame-pointer ?

Because that's the same as the non-Mac config (see line 207)

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi#newcod...
build/standalone.gypi:275: '<(DEPTH)/build/mac/asan.gyp:asan_dynamic_runtime',
On 2015/01/09 at 12:42:48, Michael Achenbach wrote:
> I don't find the same for tsan in commmon.gypi

removed

[Michael Achenbach, 2015-01-09 12:52:57]

lgtm with comments:

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi#newcod...
build/standalone.gypi:241: 'OTHER_CFLAGS+': [
OK - I just made a 1:1 comparison with common.gypi. E.g.
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...
But since this is a new feature - we can just try it out.

https://codereview.chromium.org/838383005/diff/1/build/standalone.gypi#newcod...
build/standalone.gypi:275: '<(DEPTH)/build/mac/asan.gyp:asan_dynamic_runtime',
Actually, I don't see any tsan related things for mac in common.gypi at all.
Does that work? I also didn't find a bot on memory.fyi...

[jochen (gone - plz use gerrit), 2015-01-09 12:55:45]

ok, I dropped the tsan part. I only tried asan and that worked for me

[jochen (gone - plz use gerrit), 2015-01-09 12:56:09]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-01-09 12:57:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/838383005/40001

[commit-bot: I haz the power, 2015-01-09 13:38:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-09 13:38:32]

Patchset 3 (id:??) landed as
https://crrev.com/8216f1bc7c6b4edaa4f2f9de1efa0fc6d1fe887c
Cr-Commit-Position: refs/heads/master@{#26013}

[Alexander Potapenko, 2015-01-12 08:42:26]

LGTM with a nit.

https://codereview.chromium.org/838383005/diff/40001/build/mac/asan.gyp
File build/mac/asan.gyp (right):

https://codereview.chromium.org/838383005/diff/40001/build/mac/asan.gyp#newco...
build/mac/asan.gyp:20: 'asan_iossim_dynamic':
You probably don't need to set asan_iossim_dynamic. If you do, you also need to
add the corresponding target.