Add ASAN support for Mac

build/standalone.gypi

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 183 matching lines @@
               'VCCLCompilerTool': {
                 'WarnAsError': 'false',
               },
             },
           }],
         ],
       }],
     ],
   },
   'conditions': [
-    ['asan==1', {
+    ['asan==1 and OS!="mac"', {
       'target_defaults': {
         'cflags_cc+': [
           '-fno-omit-frame-pointer',
           '-gline-tables-only',
           '-fsanitize=address',
           '-w',  # http://crbug.com/162783
         ],
-        'cflags_cc!': [
-          '-fomit-frame-pointer',
-        ],

[Michael Achenbach, 2015/01/09 12:42:48]

Why remove this? It's still in common.gypi:
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...

[jochen (gone - plz use gerrit), 2015/01/09 12:46:43]

uh, that's a mistake

         'ldflags': [
           '-fsanitize=address',
         ],
       },
     }],
-    ['tsan==1', {
+    ['tsan==1 and OS!="mac"', {
       'target_defaults': {
         'cflags+': [
           '-fno-omit-frame-pointer',
           '-gline-tables-only',
           '-fsanitize=thread',
           '-fPIC',
           '-Wno-c++11-extensions',
         ],
         'cflags!': [
           '-fomit-frame-pointer',
         ],
         'ldflags': [
           '-fsanitize=thread',
           '-pie',
         ],
         'defines': [
           'THREAD_SANITIZER',
         ],
       },
     }],
+    ['asan==1 and OS=="mac"', {
+      'target_defaults': {
+        'xcode_settings': {
+          'OTHER_CFLAGS+': [

[Michael Achenbach, 2015/01/09 12:42:48]

Why +?
Why -fno-omit-frame-pointer ?

[jochen (gone - plz use gerrit), 2015/01/09 12:46:43]

so it gets added to the list?
Because that's the same as the non-Mac config (see line 207)

[Michael Achenbach, 2015/01/09 12:52:57]

OK - I just made a 1:1 comparison with common.gypi. E.g.
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...
But since this is a new feature - we can just try it out.

+            '-fno-omit-frame-pointer',
+            '-gline-tables-only',
+            '-fsanitize=address',
+            '-w',  # http://crbug.com/162783
+          ],
+        },
+        'target_conditions': [
+          ['_type!="static_library"', {
+            'xcode_settings': {'OTHER_LDFLAGS': ['-fsanitize=address']},
+          }],
+        ],
+        'dependencies': [
+          '<(DEPTH)/build/mac/asan.gyp:asan_dynamic_runtime',
+        ],
+      },
+    }],
+    ['tsan==1 and OS=="mac"', {
+      'target_defaults': {
+        'xcode_settings': {
+          'OTHER_CFLAGS+': [
+            '-fno-omit-frame-pointer',
+            '-gline-tables-only',
+            '-fsanitize=thread',
+            '-fPIC',
+            '-Wno-c++11-extensions',
+          ],
+        },
+        'target_conditions': [
+          ['_type!="static_library"', {
+            'xcode_settings': {'OTHER_LDFLAGS': ['-fsanitize=address', '-pie']},
+          }],
+        ],
+        'dependencies': [
+          '<(DEPTH)/build/mac/asan.gyp:asan_dynamic_runtime',

[Michael Achenbach, 2015/01/09 12:42:48]

I don't find the same for tsan in commmon.gypi

[jochen (gone - plz use gerrit), 2015/01/09 12:46:43]

removed

[Michael Achenbach, 2015/01/09 12:52:57]

Actually, I don't see any tsan related things for mac in common.gypi at all.
Does that work? I also didn't find a bot on memory.fyi...

+        ],
+        'defines': [
+          'THREAD_SANITIZER',
+        ],
+      },
+    }],
     ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
        or OS=="netbsd"', {
       'target_defaults': {
         'cflags': [
           '-Wall',
           '<(werror)',
           '-W',
           '-Wno-unused-parameter',
           '-Wno-long-long',
           '-pthread',
@@ skipping 200 matching lines @@
       ],
     }],
     ['clang==1 and OS=="win"', {
       'make_global_settings': [
         # On Windows, gyp's ninja generator only looks at CC.
         ['CC', '<(make_clang_dir)/bin/clang-cl'],
       ],
     }],
   ],
 }