Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 838383004: Bring back fast/multicol/layers-split-across-columns-expected.html reftest. (Closed)

Created:
5 years, 11 months ago by mstensho (USE GERRIT)
Modified:
5 years, 11 months ago
Reviewers:
chrishtr, enne (OOO)
CC:
blink-reviews, mstensho (USE GERRIT)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Bring back fast/multicol/layers-split-across-columns-expected.html reftest. It got DRTified in https://codereview.chromium.org/688153003 Needed some minor fixing to make it pass with impl-side painting enabled. Attempt to force the creation of a transparency layer in Skia, so that the test and ref render identically. BUG=381919 R=enne@chromium.org,chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188158

Patch Set 1 : Revert relevant bits of https://codereview.chromium.org/688153003 and rebaselining that followed #

Patch Set 2 : Fix it. #

Patch Set 3 : rebase master #

Patch Set 4 : virtual/slimmingpaint/fast/multicol/layers-split-across-columns.html should pass as well now. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -573 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/multicol/layers-split-across-columns.html View 1 1 chunk +7 lines, -4 lines 0 comments Download
A LayoutTests/fast/multicol/layers-split-across-columns-expected.html View 1 1 chunk +90 lines, -0 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/layers-split-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/layers-split-across-columns-expected.txt View 1 chunk +0 lines, -65 lines 0 comments Download
D LayoutTests/platform/linux/virtual/regionbasedmulticol/fast/multicol/layers-split-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/regionbasedmulticol/fast/multicol/layers-split-across-columns-expected.txt View 1 chunk +0 lines, -77 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/layers-split-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/layers-split-across-columns-expected.txt View 1 chunk +0 lines, -65 lines 0 comments Download
D LayoutTests/platform/mac/virtual/regionbasedmulticol/fast/multicol/layers-split-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/regionbasedmulticol/fast/multicol/layers-split-across-columns-expected.txt View 1 chunk +0 lines, -77 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/layers-split-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/layers-split-across-columns-expected.txt View 1 chunk +0 lines, -65 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/regionbasedmulticol/fast/multicol/layers-split-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/regionbasedmulticol/fast/multicol/layers-split-across-columns-expected.txt View 1 chunk +0 lines, -77 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/layers-split-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/layers-split-across-columns-expected.txt View 1 chunk +0 lines, -65 lines 0 comments Download
D LayoutTests/platform/win/virtual/regionbasedmulticol/fast/multicol/layers-split-across-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/regionbasedmulticol/fast/multicol/layers-split-across-columns-expected.txt View 1 chunk +0 lines, -77 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 11 months ago (2015-01-09 10:41:35 UTC) #1
chrishtr
lgtm
5 years, 11 months ago (2015-01-09 17:06:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838383004/60001
5 years, 11 months ago (2015-01-09 17:06:43 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 17:10:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188158

Powered by Google App Engine
This is Rietveld 408576698