OOP PDF: Allow hyperlinks to be opened by print preview.

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @return {number} Width of a scrollbar in pixels
  */
 function getScrollbarWidth() {
@@ skipping 351 matching lines @@
     if (url.charAt(0) == '#') {
       // if '#' is already present in |originalUrl| then remove old fragment
       // and add new url fragment.
       var hashIndex = originalUrl.search('#');
       if (hashIndex != -1)
         url = originalUrl.substring(0, hashIndex) + url;
       else
         url = originalUrl + url;
     }
 
-    var inputURL = url;
     // If there's no scheme, add http.
-    if (inputURL.indexOf('://') == -1 && inputURL.indexOf('mailto:') == -1)
-      inputURL = 'http://' + inputURL;
+    if (url.indexOf('://') == -1 && url.indexOf('mailto:') == -1)
+      url = 'http://' + url;
 
-    // Make sure inputURL starts with a valid scheme.
-    if (inputURL.indexOf('http://') != 0 &&
-        inputURL.indexOf('https://') != 0 &&
-        inputURL.indexOf('ftp://') != 0 &&
-        inputURL.indexOf('file://') != 0 &&
-        inputURL.indexOf('mailto:') != 0) {
+    // Make sure url starts with a valid scheme.
+    if (url.indexOf('http://') != 0 &&
+        url.indexOf('https://') != 0 &&
+        url.indexOf('ftp://') != 0 &&
+        url.indexOf('file://') != 0 &&
+        url.indexOf('mailto:') != 0) {
       return;
     }
-    // Make sure inputURL is not only a scheme.
-    if (inputURL == 'http://' ||
-        inputURL == 'https://' ||
-        inputURL == 'ftp://' ||
-        inputURL == 'file://' ||
-        inputURL == 'mailto:') {
+    // Make sure url is not only a scheme.
+    if (url == 'http://' ||
+        url == 'https://' ||
+        url == 'ftp://' ||
+        url == 'file://' ||
+        url == 'mailto:') {
       return;
     }
 
     if (newTab) {
-      chrome.tabs.create({ url: inputURL });
+      // Prefer the tabs API because it guarantees we can just open a new tab.
+      // window.open doesn't have this guarantee.
+      if (chrome.tabs)
+        chrome.tabs.create({ url: url });
+      else
+        window.open(url);
     } else {
       var pageNumber =
-          this.paramsParser_.getViewportFromUrlParams(inputURL).page;
+          this.paramsParser_.getViewportFromUrlParams(url).page;
       if (pageNumber != undefined)
         this.viewport_.goToPage(pageNumber);
       else
-        window.location.href = inputURL;
+        window.location.href = url;
     }
   },
 
   /**
    * @private
    * An event handler for handling message events received from the plugin.
    * @param {MessageObject} message a message event.
    */
   handlePluginMessage_: function(message) {
     switch (message.data.type.toString()) {
@@ skipping 28 matching lines @@
       case 'getSelectedTextReply':
         this.sendScriptingMessage_(message.data);
         break;
       case 'goToPage':
         this.viewport_.goToPage(message.data.page);
         break;
       case 'loadProgress':
         this.updateProgress_(message.data.progress);
         break;
       case 'navigate':
+        // If in print preview, always open a new tab.
         if (this.isPrintPreview_)
-          break;
-        this.navigate_(message.data.url, message.data.newTab);
+          this.navigate_(message.data.url, true);
+        else
+          this.navigate_(message.data.url, message.data.newTab);
         break;
       case 'setNamedDestinations':
         this.paramsParser_.namedDestinations = message.data.namedDestinations;
         break;
       case 'setScrollPosition':
         var position = this.viewport_.position;
         if (message.data.x !== undefined)
           position.x = message.data.x;
         if (message.data.y !== undefined)
           position.y = message.data.y;
@@ skipping 214 matching lines @@
               this.streamDetails_.tabId != -1);
   },
 
   /**
    * @type {Viewport} the viewport of the PDF viewer.
    */
   get viewport() {
     return this.viewport_;
   }
 };