Issue 838153004: OOP PDF: Allow hyperlinks to be opened by print preview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 838153004: OOP PDF: Allow hyperlinks to be opened by print preview. (Closed)

Created:
5 years, 11 months ago by raymes

Modified:
5 years, 11 months ago

Reviewers:
Sam McNally

CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

OOP PDF: Allow hyperlinks to be opened by print preview. This allows links to be opened in a new window. BUG=449914 Committed: https://crrev.com/dcb7bf1cd13d2bd55ce51a62b61f209fab6aa1c5 Cr-Commit-Position: refs/heads/master@{#312160}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -21 lines)			Patch
	M	chrome/browser/resources/pdf/pdf.js	View	1	2 chunks	+27 lines, -21 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838153004/20001

5 years, 11 months ago (2015-01-20 02:28:32 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-20 03:29:28 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/dcb7bf1cd13d2bd55ce51a62b61f209fab6aa1c5
Cr-Commit-Position: refs/heads/master@{#312160}