pkg/analysis_server/lib/src/services/completion/local_computer.dart - Issue 838053003: suggest fields rather than synthetic getters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/local_computer.dart

Issue 838053003: suggest fields rather than synthetic getters (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/imported_computer.dart ('k') | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/local_computer.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/local_computer.dart b/pkg/analysis_server/lib/src/services/completion/local_computer.dart

index 2e1aa9e20ce1df861a43fe4fd95f10fa62716948..280b32e0858576f4e43499c50d474e0d14b5b270 100644

--- a/pkg/analysis_server/lib/src/services/completion/local_computer.dart

+++ b/pkg/analysis_server/lib/src/services/completion/local_computer.dart

@@ -108,15 +108,15 @@ class _LocalVisitor extends LocalDeclarationVisitor {

bool isDeprecated = _isDeprecated(fieldDecl) || _isDeprecated(varDecl);

CompletionSuggestion suggestion = _addSuggestion(

varDecl.name,

- fieldDecl.fields.type,

+ null,

fieldDecl.parent,

isDeprecated);

if (suggestion != null) {

suggestion.element = _createElement(

- protocol.ElementKind.GETTER,

+ protocol.ElementKind.FIELD,

varDecl.name,

null,

- fieldDecl.fields.type,

+ null,

false,

isDeprecated);

}