suggest fields rather than synthetic getters

pkg/analysis_server/lib/src/services/completion/local_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.local;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart' as protocol show Element,
     ElementKind;
@@ skipping 90 matching lines @@
   }
 
   @override
   void declaredField(FieldDeclaration fieldDecl, VariableDeclaration varDecl) {
     if (typesOnly) {
       return;
     }
     bool isDeprecated = _isDeprecated(fieldDecl) || _isDeprecated(varDecl);
     CompletionSuggestion suggestion = _addSuggestion(
         varDecl.name,
-        fieldDecl.fields.type,
+        null,
         fieldDecl.parent,
         isDeprecated);
     if (suggestion != null) {
       suggestion.element = _createElement(
-          protocol.ElementKind.GETTER,
+          protocol.ElementKind.FIELD,
           varDecl.name,
           null,
-          fieldDecl.fields.type,
+          null,
           false,
           isDeprecated);
     }
   }
 
   @override
   void declaredFunction(FunctionDeclaration declaration) {
     if (typesOnly) {
       return;
     }
@@ skipping 128 matching lines @@
       suggestion.element = _createElement(
           protocol.ElementKind.TOP_LEVEL_VARIABLE,
           varDecl.name,
           null,
           varList.type,
           false,
           isDeprecated);
     }
   }
 
   CompletionSuggestion _addSuggestion(SimpleIdentifier id, TypeName typeName,

[Paul Berry, 2015/01/08 19:09:35]

Consider renaming "typeName" to "returnType".  It would make it a lot easier to
understand why declaredField() passes null for this parameter.

[danrubel, 2015/01/08 19:34:40]

Good idea. Done.

       ClassDeclaration classDecl, bool isDeprecated) {
     if (id != null) {
       String completion = id.name;
       if (completion != null && completion.length > 0 && completion != '_') {
         CompletionSuggestion suggestion = new CompletionSuggestion(
             CompletionSuggestionKind.INVOCATION,
             isDeprecated ? CompletionRelevance.LOW : CompletionRelevance.DEFAULT,
             completion,
             completion.length,
             0,
@@ skipping 97 matching lines @@
     if (name == null || name.length <= 0) {
       return DYNAMIC;
     }
     TypeArgumentList typeArgs = type.typeArguments;
     if (typeArgs != null) {
       //TODO (danrubel) include type arguments
     }
     return name;
   }
 }