Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 838043003: Fix onc_to_shill translation logic error (Closed)

Created:
5 years, 11 months ago by stevenjb
Modified:
5 years, 11 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_448445_onc_guid
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ONC logic error A bug in onc_translator_onc_to_shill.cc is triggering a DCHECK when a property is set in a previously non-existent dictionary. This is a trivial fix to code that is subtle but clearly incorrect by inspection. BUG=none Committed: https://crrev.com/4081b158bd2a8984e0ba3a6457998fd35c72e070 Cr-Commit-Position: refs/heads/master@{#311357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chromeos/network/onc/onc_translator_onc_to_shill.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stevenjb
5 years, 11 months ago (2015-01-13 21:37:42 UTC) #2
armansito
lgtm
5 years, 11 months ago (2015-01-13 21:43:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838043003/1
5 years, 11 months ago (2015-01-13 22:25:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 23:07:03 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 23:07:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4081b158bd2a8984e0ba3a6457998fd35c72e070
Cr-Commit-Position: refs/heads/master@{#311357}

Powered by Google App Engine
This is Rietveld 408576698