Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chromeos/network/onc/onc_translator_onc_to_shill.cc

Issue 838043003: Fix onc_to_shill translation logic error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_448445_onc_guid
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_translator_onc_to_shill.cc
diff --git a/chromeos/network/onc/onc_translator_onc_to_shill.cc b/chromeos/network/onc/onc_translator_onc_to_shill.cc
index 9e1e53e85806c8d9735de7fddaba39fdf724ec39..fdd8fbdd8a10aad2b9a3e6c0ee425bfd9e2406ca 100644
--- a/chromeos/network/onc/onc_translator_onc_to_shill.cc
+++ b/chromeos/network/onc/onc_translator_onc_to_shill.cc
@@ -353,9 +353,10 @@ void TranslateONCHierarchy(const OncValueSignature& signature,
base::DictionaryValue* nested_shill_dict = NULL;
target_shill_dictionary->GetDictionaryWithoutPathExpansion(
*it, &nested_shill_dict);
- if (!nested_shill_dict)
+ if (!nested_shill_dict) {
nested_shill_dict = new base::DictionaryValue;
- target_shill_dictionary->SetWithoutPathExpansion(*it, nested_shill_dict);
+ target_shill_dictionary->SetWithoutPathExpansion(*it, nested_shill_dict);
+ }
target_shill_dictionary = nested_shill_dict;
}
// Translates fields of |onc_object| and writes them to
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698