Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 838003005: Don't allow text selection to start on a HTMLMediaElement (Closed)

Created:
5 years, 11 months ago by Mathias Hällman
Modified:
5 years, 6 months ago
Reviewers:
tkent, philipj_slow
CC:
blink-reviews, nessy, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't allow text selection to start on a HTMLMediaElement BUG=449146 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196741

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
A LayoutTests/media/video-controls-start-selection.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/media/video-controls-start-selection-expected.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
Mathias Hällman
5 years, 11 months ago (2015-01-15 14:42:40 UTC) #2
philipj_slow
The sensible behavior is for it to never be possible to start selecting by clicking ...
5 years, 11 months ago (2015-01-16 12:28:49 UTC) #3
philipj_slow
Looks like fast/forms/label/label-contains-other-interactive-content.html needs updating: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/43002/layout-test-results/results.html The test clicks on a video with controls, but ...
5 years, 11 months ago (2015-01-21 13:52:44 UTC) #4
philipj_slow
The change and test LGTM assuming the test failure is not indicative of some bigger ...
5 years, 11 months ago (2015-01-21 13:53:26 UTC) #5
Mathias Hällman
@tkent, could you give some input on the failing test? Is it ok to edit ...
5 years, 8 months ago (2015-04-23 14:46:16 UTC) #6
philipj_slow
Adding tkent@ to reviewers, not sure it will be noticed otherwise.
5 years, 8 months ago (2015-04-23 14:57:55 UTC) #8
tkent
On 2015/04/23 14:46:16, Mathias Hällman wrote: > @tkent, could you give some input on the ...
5 years, 8 months ago (2015-04-23 23:09:20 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838003005/20001
5 years, 6 months ago (2015-06-08 15:41:58 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-08 16:33:14 UTC) #13
philipj_slow
After minimizing the failing test case it turned out to be an unrelated bug causing ...
5 years, 6 months ago (2015-06-08 18:20:53 UTC) #14
tkent
lgtm
5 years, 6 months ago (2015-06-08 23:26:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/838003005/20001
5 years, 6 months ago (2015-06-09 07:16:38 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 07:20:16 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196741

Powered by Google App Engine
This is Rietveld 408576698