NSS: Handle unfriendly tokens in client auth.

net/ssl/client_cert_store_impl_mac.cc

Index: net/ssl/client_cert_store_impl_mac.cc
diff --git a/net/ssl/client_cert_store_impl_mac.cc b/net/ssl/client_cert_store_impl_mac.cc
index 468ff03f6ae232a86c91d7afb68b16770b945a61..25def0f7c313aaa7a347ae928665467e50288e77 100644
--- a/net/ssl/client_cert_store_impl_mac.cc
+++ b/net/ssl/client_cert_store_impl_mac.cc
@@ -172,6 +172,10 @@ void GetClientCertsImpl(const scoped_refptr<X509Certificate>& preferred_cert,
 
 }  // namespace
 
+ClientCertStoreImpl::ClientCertStoreImpl() {}
+
+ClientCertStoreImpl::~ClientCertStoreImpl() {}

[wtc, 2013/11/26 23:28:17]

Nit: It is a shame that we need to define the constructor and destructor in
three files.

If we don't declare the constructor and destructor in the header file, will the
compiler do the right thing?

[Ryan Sleevi, 2013/11/26 23:36:26]

The clang style checker will warn about a non-trivial ctor/dtor being inlined
(either the compiler generated or inlined)

However, the (maybe) splitting of this into separate classes will solve this.

We could alternatively add a ssl_client_cert_store_impl.cc with just the
ctor/dtor, but that seemed overkill, so I didn't suggest it.

+
 void ClientCertStoreImpl::GetClientCerts(const SSLCertRequestInfo& request,
                                          CertificateList* selected_certs,
                                          const base::Closure& callback) {