NSS: Handle unfriendly tokens in client auth.

net/ssl/client_cert_store_impl_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ssl/client_cert_store_impl.h"
 
 #include <CommonCrypto/CommonDigest.h>
 #include <CoreFoundation/CFArray.h>
 #include <CoreServices/CoreServices.h>
 #include <Security/SecBase.h>
@@ skipping 154 matching lines @@
   CertificateList::iterator sort_end = selected_certs->end();
   if (preferred_cert.get() && sort_begin != sort_end &&
       sort_begin->get() == preferred_cert.get()) {
     ++sort_begin;
   }
   sort(sort_begin, sort_end, x509_util::ClientCertSorter());
 }
 
 }  // namespace
 
+ClientCertStoreImpl::ClientCertStoreImpl() {}
+
+ClientCertStoreImpl::~ClientCertStoreImpl() {}

[wtc, 2013/11/26 23:28:17]

Nit: It is a shame that we need to define the constructor and destructor in
three files.

If we don't declare the constructor and destructor in the header file, will the
compiler do the right thing?

[Ryan Sleevi, 2013/11/26 23:36:26]

The clang style checker will warn about a non-trivial ctor/dtor being inlined
(either the compiler generated or inlined)

However, the (maybe) splitting of this into separate classes will solve this.

We could alternatively add a ssl_client_cert_store_impl.cc with just the
ctor/dtor, but that seemed overkill, so I didn't suggest it.

+
 void ClientCertStoreImpl::GetClientCerts(const SSLCertRequestInfo& request,
                                          CertificateList* selected_certs,
                                          const base::Closure& callback) {
   std::string server_domain =
       HostPortPair::FromString(request.host_and_port).host();
 
   ScopedCFTypeRef<SecIdentityRef> preferred_identity;
   if (!server_domain.empty()) {
     // See if there's an identity preference for this domain:
     ScopedCFTypeRef<CFStringRef> domain_str(
@@ skipping 82 matching lines @@
     const CertificateList& regular_certs,
     const SSLCertRequestInfo& request,
     CertificateList* selected_certs) {
   GetClientCertsImpl(
       preferred_cert, regular_certs, request, false, selected_certs);
   return true;
 }
 #endif
 
 }  // namespace net