Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 837923005: Revert 187544 "Remove unnecessary sync style recalc for fullscreen." (Closed)

Created:
5 years, 11 months ago by rune
Modified:
5 years, 11 months ago
Reviewers:
rune
CC:
blink-reviews
Visibility:
Public.

Description

Revert 187544 "Remove unnecessary sync style recalc for fullscreen." BUG=448721 > Remove unnecessary sync style recalc for fullscreen. > > There is no code nearby that depends on an up-to-date render tree. The > render tree will now be updated as part of WillBeginMainFrame. I've not > been able to construct a test case that can hook into the code between > the removed call and the new place since the webkitfullscreenchange event > code is called after WillBeginMainFrame. > > R=jchaffraix@chromium.org > TEST=fullscreen/ > TEST=media/ > > Review URL: https://codereview.chromium.org/816953002 TBR=rune@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M trunk/Source/core/dom/Fullscreen.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rune
5 years, 11 months ago (2015-01-15 12:01:05 UTC) #1
rune
5 years, 11 months ago (2015-01-15 12:01:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r188466.

Powered by Google App Engine
This is Rietveld 408576698