Issue 816953002: Remove unnecessary sync style recalc for fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 816953002: Remove unnecessary sync style recalc for fullscreen. (Closed)

Created:
6 years ago by rune

Modified:
6 years ago

Reviewers:
Julien - ping for review

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove unnecessary sync style recalc for fullscreen. There is no code nearby that depends on an up-to-date render tree. The render tree will now be updated as part of WillBeginMainFrame. I've not been able to construct a test case that can hook into the code between the removed call and the new place since the webkitfullscreenchange event code is called after WillBeginMainFrame. R=jchaffraix@chromium.org TEST=fullscreen/ TEST=media/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187544

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	Source/core/dom/Fullscreen.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816953002/1

6 years ago (2014-12-19 14:20:11 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-19 15:33:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187544

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages