Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 837673002: Introduce ExclusiveStreamReader. (Closed)

Created:
5 years, 11 months ago by yhirano
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce ExclusiveStreamReader. Introduce ExclusiveStreamReader, as specified in https://streams.spec.whatwg.org/. The implementation is behind a runtime flag. BUG=446121 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189417 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189555

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Patch Set 5 : rebase #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Total comments: 6

Patch Set 11 : rebase #

Patch Set 12 : #

Total comments: 12

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Patch Set 16 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1060 lines, -121 lines) Patch
A LayoutTests/http/tests/fetch/script-tests/stream-reader.js View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +91 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/stream-reader.html View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/window/stream-reader.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/stream-reader.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +6 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +6 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +6 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseProperties.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +4 lines, -0 lines 0 comments Download
A Source/core/streams/ExclusiveStreamReader.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +62 lines, -0 lines 0 comments Download
A Source/core/streams/ExclusiveStreamReader.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +198 lines, -0 lines 0 comments Download
A + Source/core/streams/ExclusiveStreamReader.idl View 1 2 3 4 5 1 chunk +11 lines, -14 lines 0 comments Download
A Source/core/streams/ExclusiveStreamReaderTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +434 lines, -0 lines 0 comments Download
M Source/core/streams/ReadableStream.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +29 lines, -8 lines 0 comments Download
M Source/core/streams/ReadableStream.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 10 chunks +110 lines, -14 lines 0 comments Download
M Source/core/streams/ReadableStream.idl View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/streams/ReadableStreamImpl.h View 1 2 3 4 5 4 chunks +10 lines, -9 lines 0 comments Download
M Source/core/streams/ReadableStreamTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 36 chunks +77 lines, -64 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/fetch/Body.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (4 generated)
yhirano
5 years, 10 months ago (2015-01-29 12:59:28 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/837673002/diff/180001/Source/core/streams/ExclusiveStreamReader.cpp File Source/core/streams/ExclusiveStreamReader.cpp (right): https://codereview.chromium.org/837673002/diff/180001/Source/core/streams/ExclusiveStreamReader.cpp#newcode55 Source/core/streams/ExclusiveStreamReader.cpp:55: } insert a blank line https://codereview.chromium.org/837673002/diff/180001/Source/core/streams/ExclusiveStreamReader.h File Source/core/streams/ExclusiveStreamReader.h (right): ...
5 years, 10 months ago (2015-02-02 04:24:11 UTC) #3
yhirano
https://codereview.chromium.org/837673002/diff/180001/Source/core/streams/ExclusiveStreamReader.cpp File Source/core/streams/ExclusiveStreamReader.cpp (right): https://codereview.chromium.org/837673002/diff/180001/Source/core/streams/ExclusiveStreamReader.cpp#newcode55 Source/core/streams/ExclusiveStreamReader.cpp:55: } On 2015/02/02 04:24:11, tyoshino wrote: > insert a ...
5 years, 10 months ago (2015-02-02 06:05:37 UTC) #4
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/837673002/diff/220001/LayoutTests/http/tests/fetch/script-tests/stream-reader.js File LayoutTests/http/tests/fetch/script-tests/stream-reader.js (right): https://codereview.chromium.org/837673002/diff/220001/LayoutTests/http/tests/fetch/script-tests/stream-reader.js#newcode32 LayoutTests/http/tests/fetch/script-tests/stream-reader.js:32: stream.getReader(); what is this getReader() call for? https://codereview.chromium.org/837673002/diff/220001/LayoutTests/http/tests/fetch/script-tests/stream-reader.js#newcode72 LayoutTests/http/tests/fetch/script-tests/stream-reader.js:72: ...
5 years, 10 months ago (2015-02-02 08:38:24 UTC) #5
yhirano
https://codereview.chromium.org/837673002/diff/220001/LayoutTests/http/tests/fetch/script-tests/stream-reader.js File LayoutTests/http/tests/fetch/script-tests/stream-reader.js (right): https://codereview.chromium.org/837673002/diff/220001/LayoutTests/http/tests/fetch/script-tests/stream-reader.js#newcode32 LayoutTests/http/tests/fetch/script-tests/stream-reader.js:32: stream.getReader(); On 2015/02/02 08:38:24, tyoshino wrote: > what is ...
5 years, 10 months ago (2015-02-02 10:21:20 UTC) #6
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/837673002/diff/220001/Source/core/streams/ReadableStreamTest.cpp File Source/core/streams/ReadableStreamTest.cpp (right): https://codereview.chromium.org/837673002/diff/220001/Source/core/streams/ReadableStreamTest.cpp#newcode33 Source/core/streams/ReadableStreamTest.cpp:33: typedef ReadableStreamImpl<ReadableStreamChunkTypeTraits<String>> StringStream; just remove the space than ...
5 years, 10 months ago (2015-02-03 06:33:25 UTC) #7
yhirano
https://codereview.chromium.org/837673002/diff/220001/Source/core/streams/ReadableStreamTest.cpp File Source/core/streams/ReadableStreamTest.cpp (right): https://codereview.chromium.org/837673002/diff/220001/Source/core/streams/ReadableStreamTest.cpp#newcode33 Source/core/streams/ReadableStreamTest.cpp:33: typedef ReadableStreamImpl<ReadableStreamChunkTypeTraits<String>> StringStream; On 2015/02/03 06:33:25, tyoshino wrote: > ...
5 years, 10 months ago (2015-02-03 07:56:21 UTC) #8
yhirano
+haraken for core/core.gypi and bindings/core/v8/ScriptPromiseProperties.h.
5 years, 10 months ago (2015-02-03 07:57:11 UTC) #10
haraken
On 2015/02/03 07:57:11, yhirano wrote: > +haraken for core/core.gypi and bindings/core/v8/ScriptPromiseProperties.h. LGTM
5 years, 10 months ago (2015-02-03 12:41:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837673002/260001
5 years, 10 months ago (2015-02-03 12:46:20 UTC) #13
commit-bot: I haz the power
Committed patchset #14 (id:260001) as https://src.chromium.org/viewvc/blink?view=rev&revision=189417
5 years, 10 months ago (2015-02-03 14:57:42 UTC) #14
dcheng
A revert of this CL (patchset #14 id:260001) has been created in https://codereview.chromium.org/901013002/ by dcheng@chromium.org. ...
5 years, 10 months ago (2015-02-04 19:48:39 UTC) #15
yhirano
reopen
5 years, 10 months ago (2015-02-05 02:18:52 UTC) #16
yhirano
I fixed the memory leak in PS16. I also included sof's change https://codereview.chromium.org/896993002. tyoshino@, can ...
5 years, 10 months ago (2015-02-05 04:16:42 UTC) #17
tyoshino (SeeGerritForStatus)
lgtm
5 years, 10 months ago (2015-02-05 07:34:05 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837673002/300001
5 years, 10 months ago (2015-02-05 07:45:28 UTC) #20
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 10:47:01 UTC) #21
Message was sent while issue was closed. 
Committed patchset #16 (id:300001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189555

Powered by Google App Engine
This is Rietveld 408576698