Introduce ExclusiveStreamReader.

Source/core/streams/ReadableStream.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/streams/ReadableStream.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptFunction.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
+#include "core/streams/ExclusiveStreamReader.h"
 #include "core/streams/UnderlyingSource.h"
 
 namespace blink {
 
 namespace {
 
 class ConstUndefined : public ScriptFunction {
 public:
     static v8::Handle<v8::Function> create(ScriptState* scriptState)
     {
         return (new ConstUndefined(scriptState))->bindToV8Function();
     }
 
 private:
     explicit ConstUndefined(ScriptState* scriptState) : ScriptFunction(scriptState) { }
     ScriptValue call(ScriptValue value) override
     {
         return ScriptValue(scriptState(), v8::Undefined(scriptState()->isolate()));
     }
 };
 
+class ResolveWithReady : public ScriptFunction {
+public:
+    static v8::Handle<v8::Function> create(ScriptState* scriptState, ReadableStream* stream)
+    {
+        return (new ResolveWithReady(scriptState, stream))->bindToV8Function();
+    }
+
+    void trace(Visitor* visitor)
+    {
+        visitor->trace(m_stream);
+        ScriptFunction::trace(visitor);
+    }
+
+private:
+    ResolveWithReady(ScriptState* scriptState, ReadableStream* stream)
+        : ScriptFunction(scriptState)
+        , m_stream(stream) { }
+
+    ScriptValue call(ScriptValue value) override
+    {
+        return ScriptValue(scriptState(), m_stream->ready(scriptState()).v8Value());
+    }
+
+    Member<ReadableStream> m_stream;
+};
+
 } // namespace
 
 ReadableStream::ReadableStream(ExecutionContext* executionContext, UnderlyingSource* source)
     : ActiveDOMObject(executionContext)
     , m_source(source)
     , m_isStarted(false)
     , m_isDraining(false)
     , m_isPulling(false)
     , m_state(Waiting)
     , m_ready(new WaitPromise(executionContext, this, WaitPromise::Ready))
     , m_closed(new ClosedPromise(executionContext, this, ClosedPromise::Closed))
 {
     suspendIfNeeded();
 }
 
 ReadableStream::~ReadableStream()
 {
 }
 
 String ReadableStream::stateString() const
 {
-    switch (m_state) {
-    case Readable:
-        return "readable";
-    case Waiting:
+    if (m_reader)
         return "waiting";
-    case Closed:
-        return "closed";
-    case Errored:
-        return "errored";
-    }
-    ASSERT(false);
-    return String();
+
+    return stateToString(m_state);
 }
 
 bool ReadableStream::enqueuePreliminaryCheck()
 {
     // This is a bit different from what spec says: it says we should throw
     // an exception here. But sometimes a caller is not in any JavaScript
     // context, and we don't want to throw an exception in such a case.
     if (m_state == Errored || m_state == Closed || m_isDraining)
         return false;
 
@@ skipping 22 matching lines @@
     }
 
     return !shouldApplyBackpressure;
 }
 
 void ReadableStream::close()
 {
     if (m_state == Waiting) {
         m_ready->resolve(ToV8UndefinedGenerator());
         m_closed->resolve(ToV8UndefinedGenerator());
+        if (m_reader)
+            m_reader->releaseLock();
         m_state = Closed;
     } else if (m_state == Readable) {
         m_isDraining = true;
     }
 }
 
-void ReadableStream::readPreliminaryCheck(ExceptionState& exceptionState)
+void ReadableStream::readInternalPreliminaryCheck(ExceptionState& exceptionState)
 {
     if (m_state == Waiting) {
         exceptionState.throwTypeError("read is called while state is waiting");
         return;
     }
     if (m_state == Closed) {
         exceptionState.throwTypeError("read is called while state is closed");
         return;
     }
     if (m_state == Errored) {
         exceptionState.throwDOMException(m_exception->code(), m_exception->message());
         return;
     }
 }
 
-void ReadableStream::readPostAction()
+void ReadableStream::readInternalPostAction()
 {
     ASSERT(m_state == Readable);
     if (isQueueEmpty()) {
         if (m_isDraining) {
             m_closed->resolve(ToV8UndefinedGenerator());
+            if (m_reader)
+                m_reader->releaseLock();
             m_state = Closed;

[tyoshino (SeeGerritForStatus), 2015/02/02 08:38:24]

this doesn't cause any real issue, but let's update m_state before releaseLock()
call as specified in the spec.

[yhirano, 2015/02/02 10:21:20]

Done.

         } else {
             m_ready->reset();
             m_state = Waiting;
         }
     }
     callPullIfNeeded();
 }
 
+ScriptValue ReadableStream::read(ScriptState* scriptState, ExceptionState& exceptionState)
+{
+    if (m_reader) {
+        exceptionState.throwTypeError("this stream is locked to an ExclusiveStreamReader");
+        return ScriptValue();
+    }
+    return readInternal(scriptState, exceptionState);
+}
+
 ScriptPromise ReadableStream::ready(ScriptState* scriptState)
 {
+    if (m_reader) {
+        return m_reader->released(scriptState).then(ResolveWithReady::create(scriptState, this));
+    }
+
+    if (m_state == Waiting) {
+        return readyInternal(scriptState).then(ResolveWithReady::create(scriptState, this));
+    }
+    return readyInternal(scriptState);
+}
+
+ScriptPromise ReadableStream::readyInternal(ScriptState* scriptState)
+{
     return m_ready->promise(scriptState->world());
 }
 
 ScriptPromise ReadableStream::cancel(ScriptState* scriptState, ScriptValue reason)
 {
+    if (m_reader)
+        return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "this stream is locked to an ExclusiveStreamReader"));
     if (m_state == Closed)
         return ScriptPromise::cast(scriptState, v8::Undefined(scriptState->isolate()));
     if (m_state == Errored)
         return ScriptPromise::rejectWithDOMException(scriptState, m_exception);
 
     ASSERT(m_state == Readable || m_state == Waiting);
     if (m_state == Waiting)
         m_ready->resolve(ToV8UndefinedGenerator());
     clearQueue();
     m_closed->resolve(ToV8UndefinedGenerator());
     m_state = Closed;
     return m_source->cancelSource(scriptState, reason).then(ConstUndefined::create(scriptState));
 }
 
 ScriptPromise ReadableStream::closed(ScriptState* scriptState)
 {
     return m_closed->promise(scriptState->world());
 }
 
 void ReadableStream::error(PassRefPtrWillBeRawPtr<DOMException> exception)
 {
     switch (m_state) {
     case Waiting:
         m_exception = exception;
         m_ready->reject(m_exception);
         m_closed->reject(m_exception);
         m_state = Errored;
+        if (m_reader)
+            m_reader->releaseLock();
         break;
     case Readable:
         clearQueue();
         m_exception = exception;
         m_ready->reset();
         m_ready->reject(m_exception);
         m_closed->reject(m_exception);
         m_state = Errored;
+        if (m_reader)
+            m_reader->releaseLock();
         break;
     default:
         break;
     }
 }
 
 void ReadableStream::didSourceStart()
 {
     m_isStarted = true;
     callPullIfNeeded();
 }
 
+ExclusiveStreamReader* ReadableStream::getReader(ExceptionState& exceptionState)
+{
+    if (m_reader) {
+        exceptionState.throwTypeError("already locked to an ExclusiveStreamReader");
+        return nullptr;
+    }

[tyoshino (SeeGerritForStatus), 2015/02/02 08:38:24]

Throw for closed and errored stream as specified in AcquireExclusiveStreamReader
the abst op?

[yhirano, 2015/02/02 10:21:20]

Done.

+    return new ExclusiveStreamReader(this);
+}
+
+void ReadableStream::setReader(ExclusiveStreamReader* reader)
+{
+    ASSERT((reader && !m_reader) || (!reader && m_reader));
+    m_reader = reader;
+}
+
 void ReadableStream::callPullIfNeeded()
 {
     if (m_isPulling || m_isDraining || !m_isStarted || m_state == Closed || m_state == Errored)
         return;
 
     bool shouldApplyBackpressure = this->shouldApplyBackpressure();
     // this->shouldApplyBackpressure may call this->error().
     if (shouldApplyBackpressure || m_state == Errored)
         return;
     m_isPulling = true;
     m_source->pullSource();
 }
 
 bool ReadableStream::hasPendingActivity() const
 {
     return m_state == Waiting || m_state == Readable;
 }
 
 void ReadableStream::trace(Visitor* visitor)
 {
     visitor->trace(m_source);
     visitor->trace(m_ready);
     visitor->trace(m_closed);
     visitor->trace(m_exception);
+    visitor->trace(m_reader);
     ActiveDOMObject::trace(visitor);
 }
 
+String ReadableStream::stateToString(State state)
+{
+    switch (state) {
+    case Readable:
+        return "readable";
+    case Waiting:
+        return "waiting";
+    case Closed:
+        return "closed";
+    case Errored:
+        return "errored";
+    }
+    ASSERT(false);
+    return String();
+}
+
 } // namespace blink