Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 837633005: Add Arithmetic mode xp. (Closed)

Created:
5 years, 11 months ago by egdaniel
Modified:
5 years, 11 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@arithGpuFile
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1

Patch Set 3 : Review nit #

Patch Set 4 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -91 lines) Patch
M src/effects/SkArithmeticMode.cpp View 1 2 2 chunks +14 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.h View 1 2 3 3 chunks +119 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 3 chunks +182 lines, -86 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
egdaniel
5 years, 11 months ago (2015-01-14 16:40:57 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/837633005/diff/20001/src/effects/SkArithmeticMode.cpp File src/effects/SkArithmeticMode.cpp (right): https://codereview.chromium.org/837633005/diff/20001/src/effects/SkArithmeticMode.cpp#newcode34 src/effects/SkArithmeticMode.cpp:34: bool asFragmentProcessor(GrFragmentProcessor**, can we one-line this guy?
5 years, 11 months ago (2015-01-14 18:07:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837633005/40001
5 years, 11 months ago (2015-01-14 20:01:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1489)
5 years, 11 months ago (2015-01-14 20:03:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/837633005/60001
5 years, 11 months ago (2015-01-14 20:42:45 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 20:53:04 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f351aa3bf1b1d7639be8e1e6a35137b89a8dd93d

Powered by Google App Engine
This is Rietveld 408576698