Make fixups reference any constant (allow const float/double pool literals).

Make fixups reference any constant (allow const float/double pool literals).

This avoids doing getConstantSym to avoid hitting the global
context's getConstantSym during emitIAS(), which may be desirable for
multi-threading, since each function's emitIAS() should be able to happen
on a separate thread.

The stringification is moved till later, so it still happens, just without
creating a constant relocatable w/ offset of 0.

This ends up tickling an issue where -O0 on 252.eon now gets 2x as many
page faults, and I'm not sure exactly why. This makes the overall time
higher, though emit time is lower.

When translating with -O2 # of page faults is about the same before/after,
so that oddness is restricted to O0.

Before this change, tweaking the slab size at O0 doesn't
seem to affect as drastically as 2x swings either.

To work around this, I turned the slab size of the assembler down to 32KB.

===

Move all the .L$type$poolid into a function (replacing getPoolEntryID).

BUG=none
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1d62cf08a2968f09e2844c74d877e16a1858fa56

[jvoung (off chromium), 2015-01-09 19:13:18]

jvoung@chromium.org changed reviewers:
+ stichnot@chromium.org

[Jim Stichnoth, 2015-01-09 22:30:35]

lgtm

https://codereview.chromium.org/837553009/diff/40001/src/IceDefs.h
File src/IceDefs.h (right):

https://codereview.chromium.org/837553009/diff/40001/src/IceDefs.h#newcode64
src/IceDefs.h:64: template <size_t SlabSize>
I was wondering if you could just parameterize ArenaAllocator, e.g.

template <size_t SlabSize = 1024 * 1024>
using ArenaAllocator = llvm::BumpPtrAllocatorImpl<llvm::MallocAllocator,
SlabSize>;

and then change the uses of ArenaAllocator to ArenaAllocator<> .

https://codereview.chromium.org/837553009/diff/40001/src/IceOperand.h
File src/IceOperand.h (right):

https://codereview.chromium.org/837553009/diff/40001/src/IceOperand.h#newcode105
src/IceOperand.h:105: Str << ".L$" << getType() << "$" << PoolEntryID;
Thanks for refactoring this, I was just noticing all the repetition.

[jvoung (off chromium), 2015-01-09 22:50:19]

Thanks

https://codereview.chromium.org/837553009/diff/40001/src/IceDefs.h
File src/IceDefs.h (right):

https://codereview.chromium.org/837553009/diff/40001/src/IceDefs.h#newcode64
src/IceDefs.h:64: template <size_t SlabSize>
On 2015/01/09 22:30:35, stichnot wrote:
> I was wondering if you could just parameterize ArenaAllocator, e.g.
> 
> template <size_t SlabSize = 1024 * 1024>
> using ArenaAllocator = llvm::BumpPtrAllocatorImpl<llvm::MallocAllocator,
> SlabSize>;
> 
> and then change the uses of ArenaAllocator to ArenaAllocator<> .

Ah yep, that seems to work. Done.

https://codereview.chromium.org/837553009/diff/40001/src/IceOperand.h
File src/IceOperand.h (right):

https://codereview.chromium.org/837553009/diff/40001/src/IceOperand.h#newcode105
src/IceOperand.h:105: Str << ".L$" << getType() << "$" << PoolEntryID;
On 2015/01/09 22:30:35, stichnot wrote:
> Thanks for refactoring this, I was just noticing all the repetition.

Acknowledged.

[jvoung (off chromium), 2015-01-09 22:57:38]

Committed patchset #4 (id:60001) manually as
1d62cf08a2968f09e2844c74d877e16a1858fa56 (presubmit successful).